feat: ADD rate-limiting functionality#1396
Open
mattclegg wants to merge 1 commit into
Open
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines! |
mattclegg
changed the title
sumanmaity112
requested changes
Jul 4, 2026
|
|
||
| private static boolean isRateLimited(HttpClientErrorException exception) { | ||
| final boolean rateLimitStatus = | ||
| FORBIDDEN.equals(exception.getStatusCode()) |
Collaborator
There was a problem hiding this comment.
429 is only rate limit status code, isn't it? FORBIDDEN is slightly different
| } | ||
| log.warn("GitHub rate limit hit; waiting {}s until reset", waitFor.toSeconds()); | ||
| try { | ||
| Thread.sleep(waitFor.toMillis()); |
Collaborator
There was a problem hiding this comment.
Wouldn't it hang the complete system? also given waitUntilRateLimitResets will be called multiple times, multiple Threads will go on sleep mode. Ideally if the rate-limit got hit, then we should skip the remaining calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting blocked when querying a large number of repositories (~2k).
Any feedback welcome.
Thanks