Extended ValidatorBuilder so (absolute) urls are resolved as well#49
Extended ValidatorBuilder so (absolute) urls are resolved as well#49Ilyes512 wants to merge 1 commit intoosteel:mainfrom
Conversation
dd71106 to
2d87985
Compare
2d87985 to
405249b
Compare
osteel
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay. A general comment for now – I appreciate that you made an extension point for one to create their own factory, but it feels a bit like overkill to me. I'd rather only add extension points when the need truly arises, and I don't expect it to be the case here. Besides, we'd need to document it and that'd make the API more complex as a result. Finally, and this may be a more important point, the interface imposes to return instances of cebe\openapi\SpecObjectInterface, which doesn't belong to this package and is out of our control
|
OK. I understand. I solved my issue by using the 2 underlying dependencies directly. Thanks for your time! |
|
Sorry – I didn't mean for you to close this! I was only saying that I don't think the extension point is necessary/desirable 🙂 Would still be nice to add support for URLs, but I would simplify your PR quite a bit, basically. I'd understand if you'd lost interest now that you solved your issue though – if that's the case, I'll probably do this myself now that I've got a good idea of how to do it (thanks to you) |
Ah, I was under the assumption that because I am returning And the main reason I opted for a factory (interface) was to make it (unit) testable. And I also agreed with the fact that it's feels more complicated than necessary. |
Summary
See #46