Skip to content

Add a v4 upgrade guide#277

Open
mnapoli wants to merge 3 commits into
4.xfrom
v4-upgrade-guide
Open

Add a v4 upgrade guide#277
mnapoli wants to merge 3 commits into
4.xfrom
v4-upgrade-guide

Conversation

@mnapoli
Copy link
Copy Markdown
Contributor

@mnapoli mnapoli commented May 19, 2026

No description provided.

@mnapoli mnapoli requested a review from GrahamCampbell May 19, 2026 20:55
Comment thread docs/guides/upgrading-to-v4.md Outdated
## What's in osls v4

- **AWS SDK v3**: osls uses the AWS SDK under the hood to interact with AWS. v4 upgrades from the deprecated AWS SDK v2 to v3.
- **IAM Identity Center (AWS SSO) support**: Thanks to the upgrade to the AWS SDK v3, the `osls` CLI now supports AWS IAM Identity Center (formerly AWS SSO) credentials.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell have you tested this is working well with the new SDK approach? (before we announce this I just want to make sure)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested SSO yet. I was hoping one of the people who opened issues about SSO would test it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I need to test it, I haven't even tried v4 yet need to dedicate some time

Comment on lines +68 to +72
| `provider.role` | `provider.iam.role` |
| `provider.rolePermissionsBoundary` | `provider.iam.role.permissionsBoundary` |
| `provider.iamRoleStatements` | `provider.iam.role.statements` |
| `provider.iamManagedPolicies` | `provider.iam.role.managedPolicies` |
| `provider.cfnRole` | `provider.iam.deploymentRole` |
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I'd like to revert. It will impact a lot of people for no gain. This was originally deprecated in serverless v2 and for v3 we walked back dropping these because how it was still used a lot. I think it's worth doing the same thing here.

(btw I'm opening this here but not related to this PR directly)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure. This will require two PRs. One to adjust v3 to say the removal is in v5 instead. One to re-add it to v4. I can handle that.

Comment thread docs/guides/upgrading-to-v4.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants