refactor(platforms): google adapter + registry changes recovered from worktree - #21
Merged
Merged
Conversation
…itted worktree Found uncommitted on `main` during a cross-project worktree sweep — it lived only on one machine, so it is committed here to be visible and reviewable rather than lost. Touches the platform adapter layer (adapter.ts, google-adapter.ts, google.ts, registry.ts) and the agent/report cron + snapshot routes. Not reviewed for correctness by the sweep. Secret-scanned clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
Review — ✅ 合并这是这批抢救 PR 里唯一一个真正有价值的功能改动,而且写得不错。 内容:Google Ads MCC 的正确处理核心洞察写在注释里,是对的:MCC(管理账户)自己没有 campaign,所以把它当 customer 去拉报表必然拿不到数据。改法是把 MCC 降格为纯 // Normalized (dash-stripped) MCC id. Used purely as login-customer-id
// context — never iterated as a customer for report queries, because the
// MCC is a manager and has no campaigns of its own.
private mccId: string几个细节做对了:
验证
那 69 个基线错误是 Prisma 生成客户端过期( 一处提醒
合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovered from an uncommitted worktree on
mainduring a cross-project sweep.Contents — platform adapter layer (
adapter.ts,google-adapter.ts,google.ts,registry.ts) plus theagent/snapshot,cron/agent,cron/dailyandreports/syncroutes.main; please review the diff before merging. Secret-scanned clean.🤖 Generated with Claude Code