docs: operator steps for sign-in by code and Google, and the env to deploy them - #293
Merged
Merged
Conversation
…eploy them deploy.sh passes an explicit env allowlist, so the two Google client ids would have been dropped silently — a deploy that looked fine and left the button invisible. Added, with the sign-in-by-code dependency on RESEND_API_KEY spelled out in the header (no key ⇒ codes only reach the server log ⇒ nobody can sign in). Runbook gains Phase 8 (verify the Resend sending domain, with a curl self-check), Phase 9 (GCP OAuth consent + the Web and iOS client ids, plus the redeploy command with both new env groups) and Phase 10 (ship a build — deliberately NOT prescribing a version bump, since whether this folds into 1.1 or becomes 1.2 depends on ASC state the repo can't see). Plan doc marked implemented with the PR chain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Docs + a genuine deploy fix. Ready to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #292. Last of the chain.
One real bug, not just docs
deploy/deploy.shbuilds an explicit env allowlist, soLISA_GOOGLE_WEB_CLIENT_ID/LISA_GOOGLE_IOS_CLIENT_IDwould have been dropped silently — a deploy that reports success and leaves the Google button invisible with no error anywhere. Both are now passed through, and the header documents the sign-in-by-code dependency onRESEND_API_KEY(without it codes only reach the server log, so nobody can complete a sign-in).Runbook
curlself-check that distinguishes "accepted" from "actually sent".Plan doc marked implemented with the PR chain and the two incidental fixes found along the way.
npm test→ 1173 green;bash -n deploy/deploy.shclean, and I checked the new allowlist lines actually emit the pairs.🤖 Generated with Claude Code