Conversation
|
|
||
| let userDataDir; | ||
| let removeUserDataDir = false; | ||
| if (options && options.userDataDir) { |
There was a problem hiding this comment.
can be simplified:
options?.userDataDir
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 705818d641
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| matchedProvider.init(prov, job.blacklist); | ||
|
|
||
| if (!browser && matchedProvider.config.getListings == null) { | ||
| browser = await puppeteerExtractor.launchBrowser(matchedProvider.config.url, {}); |
There was a problem hiding this comment.
executeJob now creates one shared browser via launchBrowser(matchedProvider.config.url, {}), which drops the options path that _getListings now forwards to Extractor (including DEFAULT_OPTIONS.puppeteerTimeout = 60000 in extractor.js). Because launchBrowser falls back to a 30s launch timeout, slower hosts/containers can time out during Chromium startup and then all Puppeteer-backed providers in that job fail to scrape. Pass provider/extractor Puppeteer options into this launch call so shared-browser runs keep prior timeout/proxy/executable behavior.
Useful? React with 👍 / 👎.
2 participants
Uh oh!
There was an error while loading. Please reload this page.