Set of minor optimizations/refactorings#39
Open
calou wants to merge 1 commit intooptimaize:masterfrom
calou:master
Open
Set of minor optimizations/refactorings#39calou wants to merge 1 commit intooptimaize:masterfrom calou:master
calou wants to merge 1 commit intooptimaize:masterfrom
calou:master
Conversation
Signed-off-by: Sébastien Gruchet <gruchet@gmail.com>
| if (priorMap != null) { | ||
| //TODO analyze and optimize this code, looks like double copy. | ||
| System.arraycopy(priorMap, 0, prob, 0, prob.length); | ||
| for(int i=0;i<prob.length;++i) prob[i] = priorMap[i]; |
There was a problem hiding this comment.
If the removal of this line is intentional, you should update the Javadoc for this method too.
Author
There was a problem hiding this comment.
The lines 203 and 204 do exactly the same job ie copying the priorMap array in the prob array. I don't think there just should be any update to the Javadoc for search a change.
There was a problem hiding this comment.
On taking a fresh look at this, I think you're right and no update is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sébastien Gruchet gruchet@gmail.com