-
Notifications
You must be signed in to change notification settings - Fork 3
update transitive dependencies #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -96,7 +96,7 @@ public JsonElement serialize(Object src, Type typeOfSrc, JsonSerializationContex | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| static public class Segment { | ||||||
| static class Segment { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
| public String hash; | ||||||
| public long segmentSize; | ||||||
| public long encryptedSegmentSize; | ||||||
|
|
@@ -167,7 +167,7 @@ public int hashCode() { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| static public class PolicyBinding { | ||||||
| static class PolicyBinding { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency with other components of the
Suggested change
|
||||||
| public String alg; | ||||||
| public String hash; | ||||||
|
|
||||||
|
|
@@ -298,7 +298,7 @@ public int hashCode() { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| static public class Binding { | ||||||
| static class Binding { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
| public String method; | ||||||
| public String signature; | ||||||
|
|
||||||
|
|
@@ -318,14 +318,14 @@ public int hashCode() { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| static public class Assertion { | ||||||
| static class Assertion { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
| public String id; | ||||||
| public String type; | ||||||
| public String scope; | ||||||
| public String appliesToState; | ||||||
| public AssertionConfig.Statement statement; | ||||||
| public Binding binding; | ||||||
| static public class HashValues { | ||||||
| static class HashValues { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
| private final String assertionHash; | ||||||
| private final String signature; | ||||||
|
|
||||||
|
|
@@ -528,7 +528,7 @@ private JWSVerifier createVerifier(RSAPublicKey publicKey) { | |||||
| } | ||||||
| } | ||||||
|
|
||||||
| public static class AssertionValueAdapter implements JsonDeserializer<AssertionConfig.Statement> { | ||||||
| static class AssertionValueAdapter implements JsonDeserializer<AssertionConfig.Statement> { | ||||||
| @Override | ||||||
| public AssertionConfig.Statement deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws JsonParseException { | ||||||
| if (!json.isJsonObject()) { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of ArchUnit is a great step for maintaining architectural integrity. Given the extensive visibility changes in this PR, you should consider adding ArchUnit rules to verify that internal implementation details (like package-private classes) do not leak through public API signatures or fields, which would help catch issues like the ones identified in
Manifest.java.