MacOS build fixes#7
Merged
ali-younis-openspace merged 1 commit intoFeb 24, 2026
Merged
Conversation
ali-younis-openspace
merged commit 03f9cb1
into
codex/rebase-4.3a1-os-compat
25 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues that prevented MacOS compilation.
Note
Low Risk
Small build-focused changes: adds a missing standard header and relaxes a member from
constto mutable storage; minimal behavioral impact but could affect code assumingmeasured_is immutable.Overview
Fixes macOS build failures by adding a missing
#include <cassert>toSL4.cppfor the use ofassert.Adjusts
TriangulationFactorto storemeasured_as non-const(wasconst Measurement), improving compatibility with compilers/operations that require assignable/movable factor instances (e.g., default construction/serialization/container use).Written by Cursor Bugbot for commit 9689925. Configure here.