Skip to content

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Jan 28, 2026

Summary by CodeRabbit

  • New Features
    • Added support for RHCOS9 operating system variant in version 4.22-main, providing an additional OS selection option.
    • Added Upgrade variant options (micro, minor, none) for version 4.22-main to give more upgrade flexibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from sosiouxme and stbenjam January 28, 2026 13:33
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

Added two variant option groups to 4.22-main in config/views.yaml: an OS variant rhcos9 and an Upgrade variant with values micro, minor, and none, placed in the include_variants block after the Network: ovn entry.

Changes

Cohort / File(s) Summary
Configuration variant additions
config/views.yaml
Added OS variant rhcos9 under 4.22-main variant_options; added Upgrade variant with values micro, minor, and none in the same block (+6/-0).

Sequence Diagram(s)

(omitted — changes are configuration additions without new multi-component control flow)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions dropping rhcos10, but the raw summary shows additions of rhcos9 and Upgrade variants with no removal of rhcos10 mentioned. Clarify whether rhcos10 was actually removed in this changeset, or if the title should reflect the additions of rhcos9 and Upgrade variants instead.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Go Error Handling ✅ Passed The pull request only modifies config/views.yaml, a YAML configuration file that does not contain any Go code changes.
Sql Injection Prevention ✅ Passed The SQL Injection Prevention check is not applicable to this pull request. The modified file is a YAML configuration file containing only static variant option definitions with no SQL queries or dynamic query construction.
Excessive Css In React Should Use Styles ✅ Passed The custom check for React inline CSS styling is not applicable to this pull request since the PR modifies only a YAML configuration file with no React components, JSX, or inline CSS styling.
Single Responsibility And Clear Naming ✅ Passed The custom check for 'Single Responsibility and Clear Naming' is not applicable to this pull request. The PR exclusively adds configuration data to a YAML file (config/views.yaml), specifically adding OS variant rhcos9 and Upgrade variant options to the 4.22-main view configuration. This check targets code-level design principles including packages, structs, methods, and their naming conventions in source code. Configuration data structures in YAML files do not fall within the scope of this code design review, which focuses on structural organization and naming practices in source code itself.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@neisw
Copy link
Contributor

neisw commented Jan 28, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026
@neisw
Copy link
Contributor

neisw commented Jan 28, 2026

/test security

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@dgoodwin
Copy link
Contributor Author

Looks like we need another lgtm after the later push on the call, sorry!

@smg247
Copy link
Member

smg247 commented Jan 29, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, neisw, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dgoodwin,neisw,smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin
Copy link
Contributor Author

/hold

Due to https://issues.redhat.com/browse/TRT-2495 this may be the only way we can reliably get rhcos 10 specific details, some of the links are bad when cross comparing.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2026
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants