Skip to content

openshift-dpf: allow to /test network PRs - #82878

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
josecastillolema:tft-scp
Aug 4, 2026
Merged

openshift-dpf: allow to /test network PRs#82878
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
josecastillolema:tft-scp

Conversation

@josecastillolema

@josecastillolema josecastillolema commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updates OpenShift DPF hypervisor network-test jobs.
  • Allows test jobs for DPF pull requests to fetch and check out the requested pull request.
  • Rebases the pull request onto OPENSHIFT_DPF_BRANCH before the tests modify .env.
  • Adds OPENSHIFT_DPF_BRANCH, defaulting to main, to control the rebase target.

Signed-off-by: Jose Castillo Lema <josecastillolema@gmail.com>

    gitleaks.version: 8.30.0
    gitleaks.check-secrets: ENABLED
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 58675386-6f1a-4106-ba22-28aae2ce5e90

📥 Commits

Reviewing files that changed from the base of the PR and between b2b0b8d and 53cbb35.

📒 Files selected for processing (2)
  • ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-commands.sh
  • ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-ref.yaml

Walkthrough

The DPF hypervisor network test step now defines OPENSHIFT_DPF_BRANCH and conditionally fetches, checks out, and rebases OpenShift DPF pull requests onto that branch.

Changes

DPF network test checkout

Layer / File(s) Summary
Base branch configuration
ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-ref.yaml
Adds OPENSHIFT_DPF_BRANCH with a default value of main.
Pull request checkout and rebase
ci-operator/step-registry/dpf/hypervisor/network-tests/dpf-hypervisor-network-tests-commands.sh
When PULL_NUMBER is set for openshift-dpf, fetches and checks out the pull request, then rebases it onto OPENSHIFT_DPF_BRANCH.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#82742: Both changes modify the DPF hypervisor network test command and reference configuration.

Suggested reviewers: tiraboschi

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: enabling /test jobs for OpenShift DPF network pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch adds PR checkout/rebase shell logic and OPENSHIFT_DPF_BRANCH configuration; it adds no It, Describe, Context, or When test titles.
Test Structure And Quality ✅ Passed The patch changes only a shell command and YAML step definition; it adds no Ginkgo test code or It blocks, so the listed Ginkgo quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The PR contains only CI infrastructure changes (bash script and YAML config) and does not add any Ginkgo e2e tests. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only a CI shell script and YAML environment configuration; it adds no Ginkgo e2e tests or multi-node assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility ✅ Passed The change only updates a CI shell step and adds OPENSHIFT_DPF_BRANCH; it introduces no manifests, controllers, replicas, affinity, tolerations, selectors, or topology constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only a shell step and YAML. It adds no OTE binary or Go/Ginkgo process-level code, so the stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only shell and YAML changes; it adds no Ginkgo e2e tests or Ginkgo test constructs, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The added code only fetches, checks out, and rebases a Git PR, plus sets an environment default; no weak crypto, custom crypto, or secret comparison appears in the patch.
Container-Privileges ✅ Passed The PR adds only PR checkout logic and OPENSHIFT_DPF_BRANCH; it adds no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Added logging reports only the pull-request number; the new lines contain no passwords, tokens, API keys, PII, session IDs, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from linoyaslan and tsorya August 4, 2026 11:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@josecastillolema

Copy link
Copy Markdown
Member Author

/assign @wabouhamad

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@josecastillolema: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-openshift-dpf-main-network-tests rh-ecosystem-edge/openshift-dpf presubmit Registry content changed
pull-ci-rh-ecosystem-edge-openshift-dpf-release-4.22-network-tests rh-ecosystem-edge/openshift-dpf presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@josecastillolema

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-rh-ecosystem-edge-openshift-dpf-main-network-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@josecastillolema

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-rh-ecosystem-edge-openshift-dpf-main-network-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@josecastillolema: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josecastillolema

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@josecastillolema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 4, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josecastillolema, linoyaslan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit ef3b40b into openshift:main Aug 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants