ROSAENG-1331: Add MC e2e testing workflow for SRE operators (RMO, AVO) - #82850
ROSAENG-1331: Add MC e2e testing workflow for SRE operators (RMO, AVO)#82850dustman9000 wants to merge 1 commit into
Conversation
|
@dustman9000: This pull request references ROSAENG-1331 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a scheduled ROSA hosted-control-plane management-cluster E2E job. The workflow provisions an HCP, prepares management-cluster credentials, runs operator tests, performs best-effort cleanup, and supports operator log collection with a namespace fallback. ChangesROSA management-cluster E2E
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ScheduledJob
participant HCPWorkflow
participant ManagementCluster
participant OperatorE2E
participant Cleanup
ScheduledJob->>HCPWorkflow: start weekly ROSA MC E2E workflow
HCPWorkflow->>ManagementCluster: provision HCP and fetch credentials
ManagementCluster->>OperatorE2E: provide verified kubeconfig
OperatorE2E-->>HCPWorkflow: run operator E2E tests
HCPWorkflow->>Cleanup: perform best-effort teardown
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/rosa/operator/mc-e2e/setup/rosa-operator-mc-e2e-setup-commands.sh`:
- Line 21: Update the connection log around the oc whoami invocation to stop
printing the Management Cluster API URL; replace the command output with a
generic confirmation that the Management Cluster connection succeeded.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: b31e44cf-0a6f-4e25-b93e-726b2e4cf820
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (7)
ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yamlci-operator/step-registry/rosa/operator/cleanup/rosa-operator-cleanup-commands.shci-operator/step-registry/rosa/operator/mc-e2e/OWNERSci-operator/step-registry/rosa/operator/mc-e2e/rosa-operator-mc-e2e-workflow.yamlci-operator/step-registry/rosa/operator/mc-e2e/setup/OWNERSci-operator/step-registry/rosa/operator/mc-e2e/setup/rosa-operator-mc-e2e-setup-commands.shci-operator/step-registry/rosa/operator/mc-e2e/setup/rosa-operator-mc-e2e-setup-ref.yaml
| cp "${MC_KUBECONFIG}" "${SHARED_DIR}/kubeconfig" | ||
| log "MC kubeconfig set for operator e2e" | ||
| KUBECONFIG="${SHARED_DIR}/kubeconfig" oc whoami | ||
| log "Connected to MC: $(KUBECONFIG="${SHARED_DIR}/kubeconfig" oc whoami --show-server)" |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Do not print the Management Cluster API URL.
oc whoami --show-server writes the cluster URL to the CI log. Replace this message with a generic connection confirmation.
Proposed fix
-log "Connected to MC: $(KUBECONFIG="${SHARED_DIR}/kubeconfig" oc whoami --show-server)"
+log "Connected to MC"As per coding guidelines, step registry command scripts must not echo cluster URLs.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| log "Connected to MC: $(KUBECONFIG="${SHARED_DIR}/kubeconfig" oc whoami --show-server)" | |
| log "Connected to MC" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/rosa/operator/mc-e2e/setup/rosa-operator-mc-e2e-setup-commands.sh`
at line 21, Update the connection log around the oc whoami invocation to stop
printing the Management Cluster API URL; replace the command output with a
generic confirmation that the Management Cluster connection succeeded.
Source: Coding guidelines
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest ci/rehearse/periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dustman9000
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add rosa-operator-mc-e2e workflow that provisions an HCP on a CI sector, fetches the MC kubeconfig, and runs operator e2e tests against the Management Cluster. Add weekly periodics for both RMO (RHOBS Synthetic Monitoring tests) and AVO (CEL validation tests) on the rosa-e2e sector. Reuses existing provision/deprovision chains with a bridge step to copy the MC kubeconfig. No operator install/cleanup since operators are fleet-managed via MCC/PKO.
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-hcp-mc-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dustman9000: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
rosa-operator-mc-e2eworkflow: provisions HCP on CI sector, fetches MC kubeconfig, runs operator e2e against the Management Clusterrosa-operator-mc-e2e-setupref: bridges MC kubeconfig path for the operator e2e steprosa-hcp-mc-e2eweekly periodic for both RMO and AVO targeting the rosa-e2e sectorRMO runs RHOBS Synthetic Monitoring tests (HCP probe lifecycle). AVO runs CEL validation tests (VpcEndpoint/VpcEndpointTemplate CRD validation). Both operators auto-detect MC mode: RMO checks for the HCP CRD, AVO tests don't need the VpcEndpointTemplate controller.
Jira: https://redhat.atlassian.net/browse/ROSAENG-1331
Test plan