Skip to content

setup assisted-installer version v2.55 - #82779

Closed
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-af477a39-7c79-47a3-82c0-219ec14c7cc7
Closed

setup assisted-installer version v2.55#82779
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-af477a39-7c79-47a3-82c0-219ec14c7cc7

Conversation

@danmanor

@danmanor danmanor commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updated Assisted Installer v2.55 CI test configurations for assisted-installer-agent and assisted-installer.
  • Set always_run: false for the affected subsystem-test and e2e-metal-assisted jobs.
  • Replaced skip_if_only_changed with pipeline_skip_if_only_changed to apply pipeline-level change filtering.

@openshift-ci

openshift-ci Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2026
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d6381d59-a25a-4610-a90f-a16cf95344fe

📥 Commits

Reviewing files that changed from the base of the PR and between 1f84254 and be89c21.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The Assisted Installer test configurations explicitly disable always-run behavior and replace skip_if_only_changed with pipeline_skip_if_only_changed.

Changes

Assisted Installer CI configuration

Layer / File(s) Summary
Update test scheduling fields
ci-operator/config/openshift/assisted-installer-agent/...yaml, ci-operator/config/openshift/assisted-installer/...yaml
The test jobs set always_run: false and use pipeline_skip_if_only_changed for file-change filtering.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup covered by the configuration changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only CI YAML metadata; no Ginkgo test-title declarations or dynamic test-name values were added.
Test Structure And Quality ✅ Passed The PR changes only CI YAML configuration and generated presubmit YAML; no Ginkgo test code, It blocks, cluster waits, or assertions are changed.
Microshift Test Compatibility ✅ Passed The PR changes only two CI YAML files; the parent-to-HEAD diff adds no Ginkgo tests or references to MicroShift-incompatible APIs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only four YAML CI configuration/job files and adds no Ginkgo test declarations or test source, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed All four changed files are ci-operator test/job YAML; the diff only changes always_run and pipeline skip annotations, with no deployment or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only four YAML CI configuration files; it adds no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff adds no Ginkgo tests or networking code; it only updates CI YAML and generated presubmit metadata.
No-Weak-Crypto ✅ Passed The commit changes only four YAML CI configuration files; added-line scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison usage.
Container-Privileges ✅ Passed The four changed YAML files contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or explicit root settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds only test scheduling fields and generated annotations; no logging commands or sensitive values are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor

danmanor commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #82822

@danmanor danmanor closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants