OCPQE-18444: Add systemd-cat logging to baremetal-lab provisioning steps - #82732
Open
jadhaj wants to merge 1 commit into
Open
OCPQE-18444: Add systemd-cat logging to baremetal-lab provisioning steps#82732jadhaj wants to merge 1 commit into
jadhaj wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@jadhaj: This pull request references OCPQE-18444 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jadhaj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
WalkthroughBare-metal lab steps now accept ChangesBare-metal auxiliary-host lifecycle logging
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-ref.yaml`:
- Around line 13-14: Ensure AUX_HOST opt-out behavior is handled before any SSH
invocation: in
ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-ref.yaml lines
13-14 and baremetal-lab-capi-commands.sh lines 17-18, and
ci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-ref.yaml
lines 14-15 and baremetal-lab-ipi-conf-bmc-verify-ca-commands.sh lines 20-21,
either require AUX_HOST or skip the prologue SSH path when it is empty so no
root@ SSH target is attempted.
In
`@ci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-commands.sh`:
- Around line 8-18: AUX_HOST is optional in the refs but used unconditionally by
both command scripts, causing failures when empty. In
ci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-commands.sh
lines 8-18 and
ci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-commands.sh
lines 11-21, guard the SSH logging calls so they run only when AUX_HOST is set;
consequently retain the empty AUX_HOST defaults in
ci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-ref.yaml
lines 13-14 and
ci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-ref.yaml
lines 13-15.
In
`@ci-operator/step-registry/baremetal/lab/ipi/conf/pxe/baremetal-lab-ipi-conf-pxe-commands.sh`:
- Around line 18-19: Move the “Disabling PXE boot” log in
baremetal-lab-ipi-conf-pxe-commands.sh to after the SELF_MANAGED_NETWORK guard,
or replace it with a neutral start message. Apply the same change to the
corresponding log in baremetal-lab-pre-dhcp-conf-commands.sh, ensuring skipped
operations are not logged as started.
In
`@ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-commands.sh`:
- Around line 8-18: Bound every diagnostic journal SSH call with a finite
end-to-end timeout, while keeping timeout failures non-fatal. Update the calls
in
ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-commands.sh
lines 8-18,
ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.sh
lines 8-18,
ci-operator/step-registry/baremetal/lab/nfs-provisioner/baremetal-lab-nfs-provisioner-commands.sh
lines 6-16, and
ci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-commands.sh
lines 8-18. Apply the same bounded, non-fatal treatment to the separate journal
calls in
ci-operator/step-registry/baremetal/lab/ipi/conf/pxe/baremetal-lab-ipi-conf-pxe-commands.sh
lines 17-19,
ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh
lines 96-97, and
ci-operator/step-registry/baremetal/lab/pre/dhcp-conf/baremetal-lab-pre-dhcp-conf-commands.sh
lines 18-20, without changing their later 10-minute operations.
In
`@ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-ref.yaml`:
- Around line 13-14: Reject an unset or empty AUX_HOST before any SSH command,
or provide the explicitly documented journal-only fallback. Apply this
consistently in
ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-ref.yaml
(13-14) and its commands.sh (15-18),
ipi/multi-arch/baremetal-lab-ipi-multi-arch-ref.yaml (13-14) and its commands.sh
(15-18), nfs-provisioner/baremetal-lab-nfs-provisioner-commands.sh (13-16), and
upi/conf/network/baremetal-lab-upi-conf-network-ref.yaml (13-14) and its
commands.sh (15-18); ensure the SSH target is never expanded as root@.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 088514a8-a47f-422a-82c8-da325fa2900a
📒 Files selected for processing (30)
ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-commands.shci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/load-balancer/baremetal-lab-ipi-conf-load-balancer-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/pxe/baremetal-lab-ipi-conf-pxe-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-ref.yamlci-operator/step-registry/baremetal/lab/ipi/deprovision/baremetal-lab-ipi-deprovision-commands.shci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.shci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.shci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-ref.yamlci-operator/step-registry/baremetal/lab/nfs-provisioner/baremetal-lab-nfs-provisioner-commands.shci-operator/step-registry/baremetal/lab/post/dhcp-pxe-conf/baremetal-lab-post-dhcp-pxe-conf-commands.shci-operator/step-registry/baremetal/lab/post/dns/baremetal-lab-post-dns-commands.shci-operator/step-registry/baremetal/lab/post/firewall/baremetal-lab-post-firewall-commands.shci-operator/step-registry/baremetal/lab/post/load-balancer/baremetal-lab-post-load-balancer-commands.shci-operator/step-registry/baremetal/lab/post/provisioning-network/baremetal-lab-post-provisioning-network-commands.shci-operator/step-registry/baremetal/lab/post/release-nodes/baremetal-lab-post-release-nodes-commands.shci-operator/step-registry/baremetal/lab/post/wipe/baremetal-lab-post-wipe-commands.shci-operator/step-registry/baremetal/lab/pre/dhcp-conf/baremetal-lab-pre-dhcp-conf-commands.shci-operator/step-registry/baremetal/lab/pre/dns/baremetal-lab-pre-dns-commands.shci-operator/step-registry/baremetal/lab/pre/load-balancer/run/baremetal-lab-pre-load-balancer-run-commands.shci-operator/step-registry/baremetal/lab/storage/baremetal-lab-storage-commands.shci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-commands.shci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-ref.yaml
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-vmedia-disk-encryption-f7 |
Contributor
|
@jadhaj: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Add systemd journal logging via systemd-cat to all baremetal-lab steps in the baremetal-lab-ipi-virtual-media workflow. Each step now logs a notice-level entry tagged with the cluster name to the bastion host's journal on step entry, enabling post-mortem debugging via `journalctl -t <cluster-name>`. For steps that previously lacked SSH infrastructure (local config generators, cluster-level oc steps), SSHOPTS and AUX_HOST env var were added to their ref YAMLs and command scripts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jadhaj
force-pushed
the
OCPQE-18444-baremetal-lab-systemd-cat-logging
branch
from
July 31, 2026 19:08
37a8267 to
018a39d
Compare
Contributor
|
[REHEARSALNOTIFIER]
A total of 659 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/baremetal/lab/post/firewall/baremetal-lab-post-firewall-commands.sh`:
- Around line 19-27: Update the SSH invocation in the disconnected firewall
deprovisioning path to pass CLUSTER_NAME through stdin, following the
argument/stdin pattern used by the DNS/load-balancer post steps. Remove the
direct interpolation of CLUSTER_NAME into the remote single-quoted command while
preserving the existing systemd-cat logging behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 7ba1db35-eb08-4242-b968-ca483aed49a3
📒 Files selected for processing (30)
ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-commands.shci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/load-balancer/baremetal-lab-ipi-conf-load-balancer-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-ref.yamlci-operator/step-registry/baremetal/lab/ipi/conf/pxe/baremetal-lab-ipi-conf-pxe-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-commands.shci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-ref.yamlci-operator/step-registry/baremetal/lab/ipi/deprovision/baremetal-lab-ipi-deprovision-commands.shci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.shci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.shci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-ref.yamlci-operator/step-registry/baremetal/lab/nfs-provisioner/baremetal-lab-nfs-provisioner-commands.shci-operator/step-registry/baremetal/lab/post/dhcp-pxe-conf/baremetal-lab-post-dhcp-pxe-conf-commands.shci-operator/step-registry/baremetal/lab/post/dns/baremetal-lab-post-dns-commands.shci-operator/step-registry/baremetal/lab/post/firewall/baremetal-lab-post-firewall-commands.shci-operator/step-registry/baremetal/lab/post/load-balancer/baremetal-lab-post-load-balancer-commands.shci-operator/step-registry/baremetal/lab/post/provisioning-network/baremetal-lab-post-provisioning-network-commands.shci-operator/step-registry/baremetal/lab/post/release-nodes/baremetal-lab-post-release-nodes-commands.shci-operator/step-registry/baremetal/lab/post/wipe/baremetal-lab-post-wipe-commands.shci-operator/step-registry/baremetal/lab/pre/dhcp-conf/baremetal-lab-pre-dhcp-conf-commands.shci-operator/step-registry/baremetal/lab/pre/dns/baremetal-lab-pre-dns-commands.shci-operator/step-registry/baremetal/lab/pre/load-balancer/run/baremetal-lab-pre-load-balancer-run-commands.shci-operator/step-registry/baremetal/lab/storage/baremetal-lab-storage-commands.shci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-commands.shci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (29)
- ci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-ref.yaml
- ci-operator/step-registry/baremetal/lab/post/load-balancer/baremetal-lab-post-load-balancer-commands.sh
- ci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-commands.sh
- ci-operator/step-registry/baremetal/lab/pre/dns/baremetal-lab-pre-dns-commands.sh
- ci-operator/step-registry/baremetal/lab/post/dns/baremetal-lab-post-dns-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-ref.yaml
- ci-operator/step-registry/baremetal/lab/post/dhcp-pxe-conf/baremetal-lab-post-dhcp-pxe-conf-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/deprovision/baremetal-lab-ipi-deprovision-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-ref.yaml
- ci-operator/step-registry/baremetal/lab/upi/conf/network/baremetal-lab-upi-conf-network-ref.yaml
- ci-operator/step-registry/baremetal/lab/nfs-provisioner/baremetal-lab-nfs-provisioner-commands.sh
- ci-operator/step-registry/baremetal/lab/pre/dhcp-conf/baremetal-lab-pre-dhcp-conf-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-ref.yaml
- ci-operator/step-registry/baremetal/lab/ipi/conf/ntp/baremetal-lab-ipi-conf-ntp-commands.sh
- ci-operator/step-registry/baremetal/lab/post/release-nodes/baremetal-lab-post-release-nodes-commands.sh
- ci-operator/step-registry/baremetal/lab/storage/baremetal-lab-storage-commands.sh
- ci-operator/step-registry/baremetal/lab/post/provisioning-network/baremetal-lab-post-provisioning-network-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/virtual-media/baremetal-lab-ipi-conf-virtual-media-commands.sh
- ci-operator/step-registry/baremetal/lab/pre/load-balancer/run/baremetal-lab-pre-load-balancer-run-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/network/vips/baremetal-lab-ipi-conf-network-vips-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-ref.yaml
- ci-operator/step-registry/baremetal/lab/ipi/conf/pxe/baremetal-lab-ipi-conf-pxe-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/conf/load-balancer/baremetal-lab-ipi-conf-load-balancer-commands.sh
- ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-ref.yaml
- ci-operator/step-registry/baremetal/lab/ipi/conf/bmc-verify-ca/baremetal-lab-ipi-conf-bmc-verify-ca-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/multi-arch/baremetal-lab-ipi-multi-arch-commands.sh
- ci-operator/step-registry/baremetal/lab/capi/baremetal-lab-capi-commands.sh
- ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh
- ci-operator/step-registry/baremetal/lab/post/wipe/baremetal-lab-post-wipe-commands.sh
Comment on lines
+19
to
+27
| CLUSTER_NAME=$(<"${SHARED_DIR}/cluster_name") | ||
|
|
||
| if [ x"${DISCONNECTED}" != x"true" ]; then | ||
| echo 'Skipping firewall configuration deprovisioning as not in a disconnected environment' | ||
| exit 0 | ||
| fi | ||
|
|
||
| timeout 10s ssh "${SSHOPTS[@]}" "root@${AUX_HOST}" \ | ||
| "systemd-cat -t '${CLUSTER_NAME}' -p5 echo 'baremetal-lab-post-firewall: Deprovisioning firewall rules'" || true |
Contributor
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n -C 6 'cluster_name|CLUSTER_NAME' ci-operator/step-registry/baremetalRepository: openshift/release
Length of output: 50374
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== candidate cluster_name producers =="
rg -n -C 3 'cluster_name|metadata:|name:|CLUSTER_NAME|UNIQUE_HASH' ci-operator/step-registry/baremetal/lab -g '*.sh' | sed -n '1,240p'
echo "== target file =="
cat -n ci-operator/step-registry/baremetal/lab/post/firewall/baremetal-lab-post-firewall-commands.sh | sed -n '1,80p'
echo "== quoting exploit simulation =="
python3 - <<'PY'
quote = r"${CLUSTER_NAME}"
payloads = ["foo", "foo'\\);date\\;\\#", "foo')\\]"}
for p in payloads:
outer = f"ssh root@aux \"systemd-cat -t '{quote}' -p5 echo 'done'\" ;"
print(p)
print(("[" + outer + "]").replace("$CLUSTER_NAME", p))
PYRepository: openshift/release
Length of output: 33179
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== all cluster_name writes =="
rg -n -C 4 'cluster_name|metadata\.name\s*=|^\s*echo\s+".*cluster_name|UNIQUE_HASH|sha256sum|base_domain|JOB_NAME|PULL_NUMBER|NAMESPACE' ci-operator/step-registry/baremetal -g '*.sh' 2>/tmp/rg-error.txt | sed -n '1,300p' || true
echo "== cluster_name reads around ssh command interpolation =="
rg -n 'CLUSTER_NAME=\$\(\<"\$\{SHARED_DIR\}/cluster_name"\)|systemd-cat -t '"'"'\${CLUSTER_NAME}'"'"'\|CLUSTER_NAME="\$\(<"\$\{SHARED_DIR\}/cluster_name"\)"' ci-operator/step-registry/baremetal -g '*.sh'Repository: openshift/release
Length of output: 42800
Pass CLUSTER_NAME through stdin before using it in the SSH command.
SHARED_DIR/cluster_name can contain a single quote in this flow, and line 27 inserts it directly into a command executed as root on AUX_HOST. That quote closes the single-quoted tag argument and lets the remaining text run as shell syntax. Use the same argument/stdin pattern as the DNS/load-balancer post steps instead.
🧰 Tools
🪛 Shellcheck (0.11.0)
[style] 21-21: Avoid x-prefix in comparisons as it no longer serves a purpose.
(SC2268)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/baremetal/lab/post/firewall/baremetal-lab-post-firewall-commands.sh`
around lines 19 - 27, Update the SSH invocation in the disconnected firewall
deprovisioning path to pass CLUSTER_NAME through stdin, following the
argument/stdin pattern used by the DNS/load-balancer post steps. Remove the
direct interpolation of CLUSTER_NAME into the remote single-quoted command while
preserving the existing systemd-cat logging behavior.
Contributor
Author
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-amd64-nightly-metal-ipi-ovn-vmedia-disk-encryption-f7 |
Contributor
|
@jadhaj: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Contributor
|
@jadhaj: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add systemd journal logging via systemd-cat to all baremetal-lab steps in the baremetal-lab-ipi-virtual-media workflow. Each step now logs a notice-level entry tagged with the cluster name to the bastion host's journal on step entry, enabling post-mortem debugging via
journalctl -t <cluster-name>.For steps that previously lacked SSH infrastructure (local config generators, cluster-level oc steps), SSHOPTS and AUX_HOST env var were added to their ref YAMLs and command scripts.
journalctl -t ci-op-lx3ym55b
baremetal-lab-pre-dhcp-conf: Configuring DHCP/PXE
Aug 01 07:20:58 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[106638]: baremetal-lab-ipi-conf-load-balancer: Generating HAProxy configuration
Aug 01 07:21:06 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[106750]: baremetal-lab-pre-load-balancer-run: Starting HAProxy load balancer
Aug 01 07:21:27 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[108041]: baremetal-lab-pre-dns: Configuring DNS records
Aug 01 07:21:36 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[108341]: baremetal-lab-ipi-conf-pxe: Disabling PXE boot
Aug 01 07:21:43 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[108436]: baremetal-lab-ipi-conf-virtual-media: Configuring Redfish virtual media
Aug 01 07:21:52 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[108579]: baremetal-lab-ipi-conf-network-vips: Configuring VIPs
Aug 01 07:22:00 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[108736]: baremetal-lab-upi-conf-network: Configuring cluster networking
Aug 01 07:22:26 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[109173]: baremetal-lab-storage: Configuring disk encryption/mirroring
Aug 01 07:22:35 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[109386]: baremetal-lab-ipi-conf-ntp: Configuring NTP servers
Aug 01 07:22:44 openshift-qe-metal-ci.arm.eng.rdu2.redhat.com ci-op-lx3ym55b[109544]: baremetal-lab-ipi-install: Starting OpenShift IPI installation
Summary by CodeRabbit
systemd-catjournal logging to baremetal-lab provisioning, configuration, installation, and cleanup steps.journalctl -t <cluster-name>.SSHOPTSandAUX_HOSTsupport to steps that lacked SSH infrastructure.OCPQE-18444. The issue has no target version, while the target branch expects5.0.0.