Skip to content

Conversation

@hongkailiu
Copy link
Member

To run openshift/cluster-version-operator#1306 correctly.

/hold

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

Details

In response to this:

To run openshift/cluster-version-operator#1306 correctly.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 26, 2026
@openshift-ci openshift-ci bot requested review from fao89 and wking January 26, 2026 07:28
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 26, 2026
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 26, 2026
@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-aws-ovn-techpreview-serial

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

The failure of the rehearsal is kind of expected:

Suite run returned error: no tests to run

Let us see if openshift/cluster-version-operator#1306 fixed it.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-aws-ovn-techpreview-serial

This one should work now as we run everything.

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DavidHurta
Copy link
Contributor

DavidHurta commented Jan 29, 2026

/lgtm
/hold

Following-up on my comment here.

The job is always_run: false. My suggestion is thus not blocking. Feel free to address it or unhold the PR.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@hongkailiu
Copy link
Member Author

hongkailiu commented Jan 30, 2026

Although, if we do not mind, I would suggest using the agnostic for the platform in the test name to explicitly indicate that we do not care, as we do with other tests:

:TIL

Oh. That is the meaning of agnostic as in e2e-agnostic-operator-techpreview. Good to know.

Now I made the new test based on e2e-agnostic-operator-techpreview now.

The job is always_run: false. My suggestion is thus not blocking.

https://docs.ci.openshift.org/docs/architecture/ci-operator/#types-of-tests

The optional: true (not always_run: false) made the job non-blocking. It is now removed too since we want to be sure we do not want to break TRT's tests.

@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-operator-techpreview-serial

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hongkailiu
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 30, 2026
@hongkailiu
Copy link
Member Author

/pj-rehearse pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 30, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hongkailiu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-techpreview-serial openshift/cluster-version-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@DavidHurta
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu
Copy link
Member Author

/pj-rehearse ack

Found what I need to see here:

started: 0/91/110 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing serial tests [Serial]"

passed: (0s) 2026-01-30T17:48:45 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing serial tests [Serial]"

@openshift-ci-robot
Copy link
Contributor

@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 1, 2026
@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2026

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 22298b2 into openshift:master Feb 1, 2026
16 checks passed
jlost pushed a commit to jlost/release that referenced this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants