single container todo/maria and todo/mongo container#2081
single container todo/maria and todo/mongo container#2081openshift-merge-bot[bot] merged 7 commits intoopenshift:oadp-devfrom
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughKubernetes E2E manifests converted mysql/mongo deployments to a unified todolist app (service, deployment, images, ports, probes, volumes); AWS PVC storageClass changed to gp2-csi; OpenStack block PVC added; Go tests updated for todoListReady signature and ginkgo.Entry usage. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
bot
added
the
approved
weshayutin
added
the
do-not-merge/hold
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/e2e/backup_restore_suite_test.go (1)
148-163:⚠️ Potential issue | 🟠 MajorParameterize hardcoded values in
VerifyBackupRestoreDatacall to matchdeploymentName.The function accepts
deploymentNameas a parameter but line 160 ignores it when callingVerifyBackupRestoreData, always passing hardcoded"todolist-route","todolist","todolist". When Mongo tests calltodoListReady(_, _, "mongo", "mongo"), they verify the todolist application instead of mongo. The pattern fromrestifyReady()(line 172) shows this should instead be parameterized—pass route and service names that correspond to the deployment being tested. Update the function signature or construct appropriate names based ondeploymentNamebefore theVerifyBackupRestoreDatacall.
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
UID mismatch after KOPIA restore -- without explicit runAsUser: 27, OpenShift assigned a namespace-range UID that changed when the namespace was recreated during restore, making the MariaDB data files inaccessible. SCC/seccomp incompatibility -- once we pinned UID 27, the restricted-v2 SCC rejected the pod (UID out of range) and the mysql-persistent-scc rejected it due to the seccompProfile setting. Removing the seccomp profile let the correct SCC match.
|
/retest |
1 similar comment
|
/retest |
weshayutin
changed the title
|
/test 4.21-e2e-test-aws |
|
/lgtm |
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
New changes are detected. LGTM label has been removed. |
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
weshayutin
added
lgtm
| volumeMode: Block | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| storageClassName: gp3-csi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mpryc, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
no flakes
Velero dev is not interested in the coordination of pods at startup.
Create a single container w/ both db and app in a single container for more consistent testing in prow.
This should avoid
start up probe issues
db connection issues