[release-4.20] OCPBUGS-78348: feat(node-deletion): remove stale LVMVolumeGroup finalizers

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2075

/assign qJkee

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 040e0be1-9545-4a3e-8fde-2a9fd9db4254

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77655 has been cloned as Jira Issue OCPBUGS-78348. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-78348: feat(node-deletion): remove stale LVMVolumeGroup finalizers

Details

In response to this:

This is an automated cherry-pick of #2075

/assign qJkee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-78348, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2075

/assign qJkee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.72%. Comparing base (042c090) to head (c4fbd7a).
⚠️ Report is 14 commits behind head on release-4.20.

Files with missing lines	Patch %	Lines
internal/controllers/node/removal/controller.go	75.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.20    #2129      +/-   ##
================================================
+ Coverage         49.43%   49.72%   +0.28%     
================================================
  Files                51       51              
  Lines              3629     3630       +1     
================================================
+ Hits               1794     1805      +11     
+ Misses             1693     1684       -9     
+ Partials            142      141       -1     

Files with missing lines	Coverage Δ
internal/controllers/node/removal/controller.go	81.15% <75.00%> (+12.04%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/snyk-deps	c4fbd7a	link	false	/test snyk-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[qJkee]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment