STOR-2809: Central TLS Profile consistency#579
STOR-2809: Central TLS Profile consistency#579dfajmon wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dfajmon: This pull request references STOR-2809 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-operator |
|
@dfajmon: This pull request references STOR-2809 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
add TLS cipher version and suites enable tls-profiles feature implement configobserver
|
@dfajmon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| func GetTLSProfileValues(ctx context.Context, c client.Client) (minVersion, cipherSuites string, err error) { | ||
| listers := &apiServerListers{&clientAPIServerLister{client: c, ctx: ctx}} | ||
| // InMemoryRecorder captures change events without logging them on every reconcile. | ||
| recorder := libevents.NewInMemoryRecorder("tls-profile", clock.RealClock{}) |
There was a problem hiding this comment.
I am not sure about using in-memory recorder here. in-memory recorder is mainly used for tests.
There was a problem hiding this comment.
I see how LocalVolumeDeviceDiscovery controller do not instantiate a proper recorder, but IMO that can be fixed and an explicit recorder passed to GetTLSProfileValues function.
3 participants
Changes include: