OCPBUGS-63502: Redeploy console pods upon cert rotation#1093
OCPBUGS-63502: Redeploy console pods upon cert rotation#1093jhadvig wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@jhadvig: This pull request references Jira Issue OCPBUGS-63502, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jhadvig: This pull request references Jira Issue OCPBUGS-63502, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7effdda to
23bcaef
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
@jhadvig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adding tracking of console-serving-cert secret, even though it's mounted as a volume at /var/serving-cert
Tracking or better say registering its informer would redeploy the console pod once the rotation occurs. Which I think should fix the issue for the OCP version which dont have conversion webhook server, so 4.17 and higher. For older versions 4.14 - 4.16 we would need to do also redeployment of the conversion webhook server.
/assgin @TheRealJon