Branch support fix - filtering in pipeline controller

[jmguzik]

No description provided.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

The code now derives a repo base reference from branch information and uses it to filter presubmit jobs during pipeline evaluation. Test data has been updated to use fully-qualified job names prefixed with repo context to align with the new filtering logic.

Changes

Cohort / File(s)	Change Summary
Pipeline filtering logic cmd/pipeline-controller/main.go	Added import of strings package. Introduced repoBaseRef variable to derive branch-scoped reference. Implemented conditional skipping for presubmits in pipelineConditionallyRequired, pipelineSkipOnlyRequired, and protected groups to check if presubmit name contains the base reference before processing.
Test data and expectations cmd/pipeline-controller/pipeline_context_test.go	Renamed JobBase Name fields from simple tokens (e.g., "test-go") to fully-qualified names with repo context prefix (e.g., "pull-ci-test-org-test-repo-main-test-go"). Updated pipeline context strings and test case expectations to match new naming convention. Adjusted skip/failure expectations to align with renamed jobs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

cmd/pipeline-controller/main.go (1)

539-586: Replace substring matching with exact branch comparison to prevent cross-branch job execution

Lines 544, 563, and 583 use strings.Contains(presubmit.Name, repoBaseRef) to filter jobs by branch. This is vulnerable when branch names share prefixes (e.g., release and release-4.16). A PR targeting release would incorrectly match jobs configured for release-4.16, causing unintended jobs to run and blocking unrelated PRs. Query the presubmit's Branches/SkipBranches fields directly using the actual base branch name, or use exact boundary matching (e.g., splitting the job name by a consistent delimiter and comparing exact segments).

[hector-vido]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hector-vido,jmguzik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7a570df and 2 for PR HEAD c186051 in total

[openshift-ci-robot]

Scheduling required tests:
/test e2e

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test integration-optional-test

[openshift-ci]

@jmguzik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	c186051	link	false	/test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.