METAL-1726: Add yet another stage for ironic-image

[elfosardo]

No description provided.

[openshift-ci-robot]

@elfosardo: This pull request references METAL-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[elfosardo]

without this I think openshift/ironic-image#786 will break the internal builds

[elfosardo]

cc @joepvd @locriandev
chicken'n'egg problem? :)

[locriandev]

/hold

This change can only happen once ironic's Dockerfile grows an extra build layer, otherwise we'd have rebase failures and stop building it.

Apart from this, the correct syntax would be:

from:
  builder:
  - member: openshift-enterprise-base-rhel9-minimal
  - member: openshift-enterprise-base-rhel9-minimal
  member: openshift-enterprise-base-rhel9-minimal

[locriandev]

@elfosardo the chicken'n'egg problem can be solved by merging this PR right after the ironic one :) Next build would find consistent config with upstream. Worst case scenario, we might miss some cycles.

[elfosardo]

@locriandev ok so the "builder" entry it does not depend on the name of the stage, it's just a list?
I think I'm going to wait to have the minimal image in CI before moving forward in any case

[locriandev]

@elfosardo that's right, builder is the allowed key and does not depend on the real stage name. also see the validator complaint

[locriandev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: locriandev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [locriandev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/retest

[openshift-ci]

@elfosardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/art-pre-commit-check	e14ff15	link	false	/test art-pre-commit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.