Skip to content

fix: stop DestinationMigrationCoordinator cycling on unrelated cluster events #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecodingshrimp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: stop DestinationMigrationCoordinator cycling on unrelated cluster events #2163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tlin/org/opensearch/alerting/util/destinationmigration/DestinationMigrationCoordinator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import org.opensearch.cluster.ClusterStateListener
import org.opensearch.cluster.service.ClusterService
import org.opensearch.common.lifecycle.LifecycleListener
import org.opensearch.common.unit.TimeValue
import org.opensearch.commons.alerting.model.ScheduledJob
import org.opensearch.threadpool.Scheduler
import org.opensearch.threadpool.ThreadPool
import org.opensearch.transport.client.Client
Expand Down Expand Up @@ -45,6 +46,8 @@ class DestinationMigrationCoordinator(
}

override fun clusterChanged(event: ClusterChangedEvent) {
if (!event.indexRoutingTableChanged(ScheduledJob.SCHEDULED_JOBS_INDEX)) return

if (DestinationMigrationUtilService.finishFlag) {
logger.info("Reset destination migration process.")
scheduledMigration?.cancel()
Expand Down