Open
Conversation
keks
force-pushed
the
keks/add-leaf-node-updates-check
branch
from
c873c8b to
1657ba1
Compare
wysiwys
requested changes
Feb 3, 2026
Collaborator
wysiwys
left a comment
wysiwys
left a comment
There was a problem hiding this comment.
Looks good to me overall. I requested one change around how fragments are added to the URLs
| in Prelude.List.map | ||
| Text | ||
| Url | ||
| (\(fragment : Text) -> "${baseUrl}#${fragment}") |
Collaborator
There was a problem hiding this comment.
For Document.Other, this step includes an extra # after the https:// for Document.Other - should this step only be performed conditionally on the Document type?
wysiwys
reviewed
Feb 3, 2026
| ( types.DocumentRef/single | ||
| '' | ||
| To that end, it requires that we check that the LeafNodes in KeyPackages | ||
| that are added support all extensions in the group context[^1]. However, it |
Collaborator
There was a problem hiding this comment.
It looks like the formatting and links aren't added for the footnote references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for making sure that leaf nodes we add in update proposals and update paths also support all extensions that are currently in the group context (not just the requried capabilities), so we can track that check in the code.
Note that the check is not explicit in the RFC, so we use the new feature from #43 that allows us to reference other source documents. Maybe the easiest way is to just review the two commits of this PR and merge them together.