fix: add permissions block and forward release_branch input#240
Merged
nexus49 merged 1 commit intofeat/releasefrom Apr 7, 2026
Merged
fix: add permissions block and forward release_branch input#240nexus49 merged 1 commit intofeat/releasefrom
nexus49 merged 1 commit intofeat/releasefrom
Conversation
Add explicit empty permissions block to release-openmfp.yml to restrict default GITHUB_TOKEN scope per least privilege principle. Add release_branch input to job-release-node.yml and forward it to job-node-test.yml so artifact uploads work for non-main branches. Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akafazov
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: {}torelease-openmfp.ymlto restrict defaultGITHUB_TOKENscope (least privilege)release_branchinput tojob-release-node.ymland forward it tojob-node-test.ymlso artifact uploads work for non-main branchesAddresses review comments on #226.