[Pushers N01] Redundant Getters #69
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout the codebase, multiple instances of redundant getter functions were identified, where an external function had been exposed to read the value of a private state variable:
_l1ScrollMessenger within ScrollPusher
_lineaRollup within LineaPusher
_zkSyncDiamond within ZkSyncPusher
_pusher within ScrollBuffer
_pusher within LineaBuffer
_pusher within ZkSyncBuffer
_newestBlockNumber within BaseBuffer
Consider removing public getter functions and instead setting the state variables to public, clarifying intent and simplifying the codebase.