Skip to content

WebGL: show status icons closer above names again and emoji on top#3983

Merged
evanpelle merged 1 commit into
mainfrom
icons-stack
May 22, 2026
Merged

WebGL: show status icons closer above names again and emoji on top#3983
evanpelle merged 1 commit into
mainfrom
icons-stack

Conversation

@VariableVince
Copy link
Copy Markdown
Contributor

@VariableVince VariableVince commented May 22, 2026

Description:

In the WebGL implementation, room was reserved for emoji icon between the status icons and the name.. This is a regression from the HTML NameLayer and it looks weird having that space sit there unused the majority of the time when no emoji is shown.

Show status icons closer above names again.

And when emoji icon is shown shortly, display it in place of the other icons (with the HTML NameLayer it would be drawn on top of the other icons but that could look messy and it's only for a short time anyway).

Not addressed in this PR: icon size is different from before WebGL implementation, they seem smaller.

BEFORE (after initial WebGL implementation):
Icons too high up because room is kept for emoji while on canvas they where stacked

AFTER:
Icons closer and stacked again just their size needs attention later on

Icons closer and stacked again just their size needs attention later on B Emoji replaces normal status icons this was after emoji was just shown

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

…oji icon needs to be shown shortly, show it in place of the other icons (with the HTML NameLayer it would be drawn on top of the other icons but that could look messy and it's only for a short time anyway).
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Review Change Stack

Walkthrough

Status icon rendering is refined through two coordinated changes: the draw order is adjusted so status icons render before standard icons, and the vertical offset configuration is decreased from 2.5 to 1.4 to reposition the status row on screen.

Changes

Status Icon Rendering

Layer / File(s) Summary
Status icon draw order and positioning
src/client/render/gl/passes/name-pass/index.ts, src/client/render/gl/render-settings.json
Status icons are now drawn before standard icons in the GPU pipeline, and the vertical offset for the status row configuration is adjusted from 2.5 to 1.4 to refine positioning.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

UI/UX

Suggested reviewers

  • evanpelle

Poem

🎨 Status icons rise to the front,
Drawn first, before the rest of the hunt,
Offset adjusted, precise and light,
From 2.5 down to 1.4—just right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: repositioning status icons closer to names and ensuring emoji displays on top, which matches the primary modifications in both the NamePass draw order and statusRowOffset adjustment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the changes: repositioning status icons closer to names (adjusting statusRowOffset from 2.5 to 1.4) and reordering GPU program draw calls to display emoji in place of status icons instead of reserving space for them.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management May 22, 2026
@evanpelle evanpelle merged commit ff11d6b into main May 22, 2026
19 checks passed
@evanpelle evanpelle deleted the icons-stack branch May 22, 2026 09:31
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants