fix: add scroll to modal content when fullscreen#38859
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The scroll is now implemented in upstream and we don't it here. Depends on openedx/openedx-platform#38859 to handle fullscreen scrolling
Studio modal doesn't allow authors to scroll when content is longer than the screen height, so this commit adds a max-height based on screen height.
And still provide scroll if content is longer than the screen height.
06bdab8 to
017c7d7
Compare
|
👍
|
Description
Studio modal doesn't allow authors to scroll when content is longer than the screen height, so this commit adds a max-height based on screen height.
Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4368Testing instructions
Note: This bug mostly concerns legacy xblock editors (text, video and problem blocks editors do not open inside an iframe), but most of them have there own scroll implementation for its content so you won't be able to reproduce the issue with drag-and-drop, word-cloud, open-response etc.
Deadline
None.