feat!: Assume that scope IDs are opaque key objects (WIP) #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
BREAKING CHANGE: Raise an exception when scope IDs are missing or are not the expected types. In particular, definition IDs must be DefinitionKey instances and usage IDs must be UsageKey instances. This has been effectively true within edx-platform (the lone production client of the XBlock library) for a long time, but explictly enforcing it will now allow us to add strong type annotations to XBlock in an upcoming release. Bump version to 6.0.0. Closes: openedx#708
kdmccormick
force-pushed
the
kdmccormick/scope-id-types
branch
from
e7ed235 to
d4e5e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Bumps XBlock version to 6.0.0
Part of: #708