test(ratelimit): cover WithInterceptorLogger and WithRejectedCounter#394
Open
zeevdr wants to merge 1 commit into
Open
test(ratelimit): cover WithInterceptorLogger and WithRejectedCounter#394zeevdr wants to merge 1 commit into
zeevdr wants to merge 1 commit into
Conversation
…Counter Both options had no direct test — they could be silently ignored without any failure. WithInterceptorLogger is verified by checking that health-check calls produce a debug log entry on the supplied logger. WithRejectedCounter is verified by checking that a rejected unary call increments the counter exactly once, using a noop-embedded stub that captures Add calls. Co-Authored-By: Claude <noreply@anthropic.com> Closes #300
zeevdr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithInterceptorLoggerandWithRejectedCounterhad no tests — they could be silently dropped from the wiring without any failure catching it.WithInterceptorLoggeris exercised by confirming that a health-check call writes the expected debug log entry to the supplied logger.WithRejectedCounteris exercised by confirming that a rejected unary call increments the counter exactly once, using a lightweightnoop-embedded stub that capturesAddcalls without pulling in the full OTel SDK.Test plan
TestWithInterceptorLogger— health-check call with a zero-capacity limiter passes (exempt), and the custom logger receives the"rate limit exempt"debug entry.TestWithRejectedCounter— non-exempt call with a zero-capacity limiter is rejected withResourceExhausted, and the counter records exactly 1 increment.go test ./internal/ratelimit/....make lintpasses.Closes #300
🤖 Generated with Claude Code