test(config): add integration test for WithGuard option#393
Open
zeevdr wants to merge 1 commit into
Open
Conversation
WithGuard had no test — the option could be silently ignored without any test catching it. Two cases cover the full contract: a rejecting guard causes the first auth-gated call to fail with PermissionDenied, and a permissive guard lets the same call succeed. Co-Authored-By: Claude <noreply@anthropic.com> Closes #304
zeevdr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithGuardhad no test — the option could be silently ignored (e.g., a wiring mistake inNewService) without any test catching it.PermissionDenied, and a permissive guard lets the same call succeed end-to-end.stubGuardtype implements theauthz.Guardinterface with a fixed return value, keeping the test self-contained without new production code.Test plan
TestNewService_WithGuard_ReplacesDefaultGuard— custom guard returningPermissionDeniedis honoured; call fails with that code.TestNewService_WithGuard_AllowAll— custom guard returning nil allowsGetConfigto complete successfully.go test ./internal/config/....make lintpasses.Closes #304
🤖 Generated with Claude Code