refactor: consolidate stream-wrapper types into internal/grpcutil#389
Merged
Conversation
…pcutil Three packages (auth/jwt, auth/metadata, server) each defined their own private struct to override a gRPC ServerStream's context. All three were structurally identical. This introduces a single grpcutil.WrappedStream with a NewWrappedStream constructor and replaces all three local copies. Co-Authored-By: Claude <noreply@anthropic.com> Closes #297
zeevdr
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth/jwt,auth/metadata,server) each defined a private struct to override a gRPCServerStream's context. All three were structurally identical — embedgrpc.ServerStream, store acontext.Context, overrideContext().grpcutil.WrappedStream(with aNewWrappedStreamconstructor) eliminates the duplication and gives future interceptors a single well-known type to use or extend.Test plan
make testtests pass — the change is purely structural, with no behavioral difference.make lintpasses (gofumpt, golangci-lint).Closes #297
🤖 Generated with Claude Code