Skip to content

Add iswaitlisted single project - #200

Merged
g-bar merged 37 commits into
mainfrom
add-iswaitlisted-single-project
Jul 30, 2026
Merged

Add iswaitlisted single project#200
g-bar merged 37 commits into
mainfrom
add-iswaitlisted-single-project

Conversation

@g-bar

@g-bar g-bar commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Sorry I forgot to add is_waitlisted to the single project endpoint response in my previous PR, this adds it.

@github-actions

Copy link
Copy Markdown

/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/safety/auth/main.py:6: AuthlibDeprecationWarning: authlib.jose module is deprecated, please use joserfc instead.
It will be compatible before version 2.0.0.
from authlib.jose import jwt

poetry audit report

Loading...
Scanning 109 packages...

• starlette installed 0.52.1 affected <1.1.0 CVE CVE-2026-48818
• starlette installed 0.52.1 affected <1.1.0 CVE CVE-2026-48817
• starlette installed 0.52.1 affected <1.3.0 CVE CVE-2026-54282
• starlette installed 0.52.1 affected >=0.4.1,<1.3.1 CVE CVE-2026-54283
• starlette installed 0.52.1 affected <1.0.1 CVE CVE-2026-48710

5 vulnerabilities found in 1 packages

@g-bar
g-bar requested review from bilalesi and pgetta July 29, 2026 16:12
@g-bar
g-bar marked this pull request as ready for review July 29, 2026 16:13

@pgetta pgetta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We will need to make sure that the projects with such status show up in the Core Web app only where they need to (from what I remember there are multiple places one can see list of projects).

@g-bar
g-bar merged commit 8b57762 into main Jul 30, 2026
5 checks passed
@g-bar

g-bar commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Nice!

We will need to make sure that the projects with such status show up in the Core Web app only where they need to (from what I remember there are multiple places one can see list of projects).

Where does it show up other then the side bar?
Capture d’écran 2026-07-30 à 08 11 48

Also adding it to the get project response is for the usecase where they go directly to the home page without going through the side menu, currently if they can't fetch the project we redirect to sync which redirects to their last visited project I think. But now we need to do that even if they can fetch if it's waitlisted we need to redirect too.

Furthermore we need to improve UX when they go to pages other than the homepage. This is what currently happens if you go to a page (other than home) in a project where you have access to the parent vlab but not the project.

Capture d’écran 2026-07-30 à 08 16 00

@g-bar
g-bar deleted the add-iswaitlisted-single-project branch July 30, 2026 06:17
@pgetta

pgetta commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Yeah, you are right, probably now it's in a single place you've made a screenshot for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants