set range and global on the fly - #625
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@darshanmandge can you have a look at it when you have some time? |
| # TODO: what should be the behavior when we do not have the client? | ||
| return "RANGE" | ||
|
|
||
| model = db_client.get_entity( |
There was a problem hiding this comment.
I would expect that a call to entitysdk for an ion channel, then filtering the selected variable each time for new channel selection, would slow down the UI experience. Do you know how long the code would take to execute?
The mapped-circuit-properties endpoint already returns the variable with just one call to entitysdk for an emodel, since the emodel entity contains the ion_channel_models field.
There was a problem hiding this comment.
that would not happen at the channel selection step, but when the user generate the simulations.
I don't think it would take much time, as long as the user have selected a reasonable number of models
Instead of relying on what the user gives as the variable type, use entitysdk to fetch the ion channel model metadata and determine if the variable is in RANGE or GLOBAL.
proposed by @james-isbister
Caveat: what to use if the user is testing locally and do not provide any db_client?