Skip to content

set range and global on the fly - #625

Open
AurelienJaquier wants to merge 2 commits into
mainfrom
range-global-on-the-fly
Open

set range and global on the fly#625
AurelienJaquier wants to merge 2 commits into
mainfrom
range-global-on-the-fly

Conversation

@AurelienJaquier

Copy link
Copy Markdown
Contributor

Instead of relying on what the user gives as the variable type, use entitysdk to fetch the ion channel model metadata and determine if the variable is in RANGE or GLOBAL.

proposed by @james-isbister

Caveat: what to use if the user is testing locally and do not provide any db_client?

@codecov

codecov Bot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/neuronal_manipulations/neuronal_manipulations.py 30.43% 16 Missing ⚠️
obi_one/scientific/library/emodel_parameters.py 33.33% 2 Missing ⚠️
Flag Coverage Δ
pytest 62.00% <35.71%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...scientific/tasks/generate_simulations/task/task.py 56.92% <100.00%> (ø)
obi_one/scientific/library/emodel_parameters.py 22.40% <33.33%> (+0.30%) ⬆️
...s/neuronal_manipulations/neuronal_manipulations.py 50.84% <30.43%> (-14.27%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AurelienJaquier

Copy link
Copy Markdown
Contributor Author

@darshanmandge can you have a look at it when you have some time?

# TODO: what should be the behavior when we do not have the client?
return "RANGE"

model = db_client.get_entity(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that a call to entitysdk for an ion channel, then filtering the selected variable each time for new channel selection, would slow down the UI experience. Do you know how long the code would take to execute?

The mapped-circuit-properties endpoint already returns the variable with just one call to entitysdk for an emodel, since the emodel entity contains the ion_channel_models field.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would not happen at the channel selection step, but when the user generate the simulations.
I don't think it would take much time, as long as the user have selected a reasonable number of models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants