Solves a timing problem when the vehicle is plugged in and the RFID tag has not yet been recognized.#3229
Open
dawys wants to merge 4 commits intoopenWB:masterfrom
Open
Solves a timing problem when the vehicle is plugged in and the RFID tag has not yet been recognized.#3229dawys wants to merge 4 commits intoopenWB:masterfrom
dawys wants to merge 4 commits intoopenWB:masterfrom
Conversation
added 2 commits
March 22, 2026 10:12
the transaction remains traceable even after the websocket performs a reconnect
… set check if the chargebox ID is set in the backend and if the rfid tag or the vehicle ID has been detected
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the OCPP flow to avoid starting/sending OCPP data too early (e.g., when a vehicle is plugged in but the RFID/vehicle ID is not yet available), and ensures MeterValues are associated with the active OCPP transaction.
Changes:
- Pass
transaction_idinto OCPPMeterValuescalls (transfer_values) so meter data is tied to the correct transaction. - Gate
StartTransactionso it is only triggered once a chargebox ID and an RFID/vehicle ID are present (to address the timing issue described in the PR title).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages/control/optional.py |
Updates OCPP meter value transfer call to include ocpp_transaction_id. |
packages/control/ocpp.py |
Extends transfer_values to include and forward transaction_id into call.MeterValues. |
packages/control/chargepoint/chargepoint.py |
Changes when start_transaction() is invoked, requiring chargebox ID and RFID/vehicle ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
copilot suggestions gepushed |
LKuemmel
requested changes
Apr 2, 2026
Contributor
LKuemmel
left a comment
LKuemmel
left a comment
There was a problem hiding this comment.
Bitte noch die Flake8 Meldung beseitigen, der Rest passt so.
Author
|
Danke, erledigt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More information is available here:
https://forum.openwb.de/viewtopic.php?t=11971