Skip to content

SPECS: spirv-cross: Add static sub-package for cmake support - #1002

Merged
misaka00251 merged 1 commit into
openRuyi-Project:mainfrom
woqidaideshi:spirv-cross
Aug 12, 2026
Merged

SPECS: spirv-cross: Add static sub-package for cmake support#1002
misaka00251 merged 1 commit into
openRuyi-Project:mainfrom
woqidaideshi:spirv-cross

Conversation

@woqidaideshi

@woqidaideshi woqidaideshi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

The CMake config file references libspirv-cross-c.a, but the spec file was deleting it during %install, causing find_package(spirv_cross_c CONFIG) to fail.

Move the static libraries into a -static subpackage instead of removing them, so the CMake package config is satisfied.

Related Issue

  • Resolves #

Checklist

Assisted-by:

@openruyi-bot openruyi-bot Bot added BuildSystem: cmake Issue/PR related to cmake BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Ready For Review Ready for review by anyone with domain expertise. labels Jul 23, 2026
@Z572
Z572 requested a review from Icenowy July 24, 2026 09:05
@Icenowy

Icenowy commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I'm okay about this.

BTW SPIRV related things seem to have no stable .so ABI usually.

@openruyi-bot openruyi-bot Bot added Workflow: In Review Issues that are undergoing code review and/or undergoing design review. and removed Workflow: Ready For Review Ready for review by anyone with domain expertise. labels Aug 12, 2026
@misaka00251 misaka00251 added this to the 2026.08 milestone Aug 12, 2026
@misaka00251
misaka00251 merged commit 6aa240d into openRuyi-Project:main Aug 12, 2026
4 checks passed
@openruyi-bot openruyi-bot Bot added Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary. and removed Workflow: In Review Issues that are undergoing code review and/or undergoing design review. labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BuildSystem: cmake Issue/PR related to cmake BuildSystem. Target: Rolling Targeting rolling/current branch. Workflow: Complete Applied after all MRs have merged and the issue has been verified if necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants