Skip to content

opentelemetry-instrumentation-aiohttp-client: add type checking support #4006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xrmx merged 4 commits into from
Dec 22, 2025
Merged

opentelemetry-instrumentation-aiohttp-client: add type checking support #4006

xrmx merged 4 commits into from
Dec 22, 2025

Conversation

@herin049
Copy link
Contributor

@herin049 herin049 commented Dec 5, 2025

Description

Add type checking support for the opentelemetry-aiohttp-client package.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tox -e typecheck

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated

@herin049 herin049 requested a review from a team as a code owner December 5, 2025 05:07
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Dec 5, 2025
@xrmx
Copy link
Contributor

xrmx commented Dec 10, 2025

@herin049 If you are using aiohttp-client at work, wdyt of adding yourself as component owner?

@herin049
Copy link
Contributor Author

herin049 commented Dec 10, 2025 •
edited
Loading

@herin049 If you are using aiohttp-client at work, wdyt of adding yourself as component owner?

Absolutely. We use aiohttp pretty extensively. We also use AWS Lambda + requests so if component owners are needed for the aws-lambda or requests instrumentation packages, I can be added there too. Let me know what you think, I can create a new PR to add myself to the relevant packages.

tammy-baylis-swi
tammy-baylis-swi reviewed Dec 10, 2025
View reviewed changes
tammy-baylis-swi
tammy-baylis-swi approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this is quite helpful!

@herin049 herin049 force-pushed the aiohttp-client-typechecking branch from ee3d706 to 2970295 Compare December 10, 2025 19:03
@herin049 herin049 force-pushed the aiohttp-client-typechecking branch from 2970295 to 417f1a2 Compare December 10, 2025 19:07
@herin049
Copy link
Contributor Author

herin049 commented Dec 10, 2025

@herin049 If you are using aiohttp-client at work, wdyt of adding yourself as component owner?

Update the PR to include myself as a component owner for aiohttp-client, I'll add myself as a component owner to other repos in a another PR

@xrmx xrmx merged commit 97b762f into open-telemetry:main Dec 22, 2025
658 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in @xrmx's Python PR digest Dec 22, 2025
herin049 added a commit to herin049/opentelemetry-python-contrib that referenced this pull request Dec 22, 2025
@herin049 @xrmx
opentelemetry-instrumentation-aiohttp-client: add type checking suppo…
e936929 
…rt (open-telemetry#4006)

* opentelemetry-instrumentation-aiohttp-client: add type checking support

* update CHANGELOG.md

* add herin049 to component owners for aiohttp-client

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

@herin049 herin049

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@herin049 @xrmx @tammy-baylis-swi