chore: update release please pipeline to support release immutability#488
Open
erka wants to merge 2 commits into
Open
chore: update release please pipeline to support release immutability#488erka wants to merge 2 commits into
erka wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 84.02% 84.12% +0.09%
==========================================
Files 27 27
Lines 2085 2085
==========================================
+ Hits 1752 1754 +2
+ Misses 293 292 -1
+ Partials 40 39 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release configuration by adding a schema and draft settings to release-please-config.json and configuring GoReleaser to use existing drafts. The review feedback identifies a schema violation where the signoff property should be a boolean rather than a string, and recommends using the github_release section in .goreleaser.yaml to align with GoReleaser v2 deprecations.
sahidvelji
approved these changes
Apr 25, 2026
Updates release-please-action to v4.4.1, introducing support for forced Git tag creation. With this change, a draft release would be created as part of the release-please-action step. GoReleaser then picks up that draft, upload the necessary build artifacts, and complete the release process. This allows to enable GitHub release immutability. <!-- add the description of the PR here --> - Add explicit contents: write, pull-requests: write, and issues: write permissions - Enable `force-tag-creation: true` to precreate git release tag - Enable `use_existing_draft: true` in goreleaser to reuse draft release created by release-please action - Add signoff for commit attribution compliance Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
force-pushed
the
rd/release-please-update
branch
from
02b664d to
30a7afc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Updates release-please-action to v4.4.1, introducing support for forced Git tag creation.
With this change, a draft release would be created as part of the release-please-action step. GoReleaser then picks up that draft, upload the necessary build artifacts, and complete the release process. This allows to enable GitHub release immutability.
force-tag-creation: trueto precreate git release taguse_existing_draft: truein goreleaser to reuse draft releasecreated by release-please action
Related Issues
#457