Skip to content

feat: add scene member list#77

Merged
will-moore merged 4 commits into
ome:mainfrom
jo-mueller:add-scene-member-list
Jun 11, 2026
Merged

feat: add scene member list#77
will-moore merged 4 commits into
ome:mainfrom
jo-mueller:add-scene-member-list

Conversation

@jo-mueller

Copy link
Copy Markdown
Contributor

Hi @will-moore , small(-ish) PR to add a more concise list of member images on the top of the scene frame. I left the scene graph as it is, but I thought for navigation this could be a bit easier to have a simple list up on top.

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for ome-ngff-validator ready!

Name Link
🔨 Latest commit af92031
🔍 Latest deploy log https://app.netlify.com/projects/ome-ngff-validator/deploys/6a2b188e320c330008bb049b
😎 Deploy Preview https://deploy-preview-77--ome-ngff-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@will-moore

Copy link
Copy Markdown
Member

Thanks for the PR...
Testing at https://deploy-preview-77--ome-ngff-validator.netlify.app/?source=https://radosgw.public.os.wwu.de/s2v/P2A_B6_M2.ome.zarr/

Screenshot 2026-06-09 at 14 48 32

It's great to see the validation of all the images in the Scene.

I think it would be nice to move the images list below the left column (where there is plenty of white space) instead of in the right, which pushes the Scene graph out of view.

I kinda like the idea of adding Thumbnails to each item, but this maybe an overkill as we already have thumbnails in the Scene graph itself. NB: it looks like thumbnails aren't working (vizarr fails too) because the server is returning 403 for .zattrs instead of 404. zarrita.js will typically try to load .zattrs by default and only check for zarr.json if it gets a 404. I guess it should be possible to work-around that, or fix the server, or both.

I didn't realise initially that the green checks were links - It would be nice if the whole row was a link - the hover color change suggested it might be clickable.
Minor point: would be nice to use the same "green" color for those check-marks as the main checkmark on the left. And the table header should use the same text-align center as the rows (or vice versa)

@jo-mueller

Copy link
Copy Markdown
Contributor Author

@will-moore I have moved the member list to the left hand site and made everything. Disclaimer: AI involved 😬 I'll add some thoughts on improving the transform graph in the thread of #78

@will-moore

Copy link
Copy Markdown
Member

Layout looks good, links are working as expected. Just the "green" color issue remaining.

@jo-mueller

Copy link
Copy Markdown
Contributor Author

Oh, hadn#t even noticed the difference in green! Changed in af92031

Maybe there's value in replacing the checkmark icon elsewhere as well with the BsCheckCircleFill object from the svelte-icons-pack for less code to maintain?

@will-moore will-moore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx

@will-moore will-moore merged commit 21af01a into ome:main Jun 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants