Use CAMB alpha at target redshift for grafic output - #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| void setCambDat(std::string cambFilePath) { | ||
| spectrum = std::make_unique<cosmology::CAMB<GridDataType>>(this->cosmology, cambFilePath); | ||
| const T targetRedshift = std::isnan(isocurvatureRedshift) ? cosmology.redshift : isocurvatureRedshift; | ||
|
|
||
| spectrum = std::make_unique<cosmology::CAMB<GridDataType>>(this->cosmology, cambFilePath, targetRedshift); |
There was a problem hiding this comment.
When the user does not supply a target_redshift, setCambDat now always passes cosmology.redshift into the CAMB constructor because isocurvatureRedshift starts as NaN. That overrides CAMB’s default isocurvature_redshift of 21.0, so the growth rescale used in CAMB::setIsocurvatureRedshift and the resulting alpha coefficient are computed at the initial-condition redshift (e.g. z≈99) instead of the previous default of z=21. This silently changes the baryon/CDM split for all existing configurations that relied on the old default. Consider keeping the constructor default when target_redshift is unspecified.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task