-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[ADD] General: User portal rework and addition #15777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
|
Hi @theRealThagomizer, this PR looks to be a real lift! The portal.rst page has been replaced by user_portal.rst, correct? could you create a redirect link for that? |
Done! The next commit has an updated redirect file. |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goodness- what a BEAST of a doc as usual @theRealThagomizer! I had a lot of edits and suggestions - some are optional/stylistic, others I think would help with structure and detail. Take what you will, ignore the rest, and tag me when it's ready for another look =) Also, I apologize- I tend to make comments before reading thorugh a whole odc, so you'll see my htought process as I went along =D
content/applications/general/users/user_portals/portal_access.rst
Outdated
Show resolved
Hide resolved
content/applications/general/users/user_portals/portal_access.rst
Outdated
Show resolved
Hide resolved
content/applications/general/users/user_portals/portal_access.rst
Outdated
Show resolved
Hide resolved
| .. note:: | ||
| Changing the :guilabel:`Email Address` (or login) only changes the *username* on the user's | ||
| portal login. | ||
|
|
||
| In order to change the contact email, this change needs to take place on the contact template in | ||
| the **Contacts** app. Alternatively, the user can change their email directly from the portal, | ||
| but their login **cannot** be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little ocnfused- do they not use an email as the "username"? Am i correct to infer that the email on this page, is what they type in the portal login? I understand that the Contact email is separate form the portal user- but would someone just write in a name/handle in the email field? Like "awesomeportaluser" or does it need to be an actual email? I feel like 99.9% of peopple would use an email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. 99% of the time, a user would just use an email, but they can set a standalone username to log in with. Updating the username doesn't update the user's email address, and users can update their own email addresses but not their own logins. I've rewritten this section to be a bit more clear.
content/applications/general/users/user_portals/updating_portal_info.rst
Outdated
Show resolved
Hide resolved
| the **Contacts** app. Alternatively, the user can change their email directly from the portal, | ||
| but their login **cannot** be changed. | ||
|
|
||
| Changing passwords |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Changing passwords | |
| Update passwords | |
| ~~~~~~~~~~~~~~~ |
I think this should be nested in the 'admin changes' like the emails, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch on both parts!
content/applications/general/users/user_portals/updating_portal_info.rst
Outdated
Show resolved
Hide resolved
| .. seealso:: | ||
| :doc:`Access rights </applications/general/users/access_rights>` | ||
| :doc:`Portal access documentation <portal_access>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. seealso:: | |
| :doc:`Access rights </applications/general/users/access_rights>` | |
| :doc:`Portal access documentation <portal_access>` | |
| .. seealso:: | |
| - :doc:`Access rights </applications/general/users/access_rights>` | |
| - :doc:`Portal access documentation <portal_access>` |
These appear net to each other, so if it's bulleted they won't be squished, or you can add a space between the lines.

Co-authored-by: Lara Martini <[email protected]>
f848e7d to
e0f5daf
Compare
|
@larm-odoo I took another pass at this following your suggestions. Thanks for the review! (if it doesn't get reviewed earlier while you're out on holiday. And if it does, happy holidays!) |


Hiya, @larm-odoo! Here are the user portal pages I've been mentioning in the past couple stand-ups. This is a mixture of all-new material and extant material that's been revised and rearranged in a new format. It's meant to capture the broad strokes of the user portal and its default features without going to deep into specific app integrations at this time. Thanks for the review!
@auva-odoo, I saw a few comments on tasks where you mentioned that there should be a dedicated customer/user portal page, so I thought you'd want to take a look at these. Please let me know if you have any feedback or if there's anything I'm missing/not representing correctly. Thanks!
This 19.0 PR can be FWP up to master.