Skip to content

Conversation

@erjer-odoo
Copy link
Contributor

Updating documentation for scrapping in Odoo for 19.1 release.

  • Updating language to match 19.1.
  • Adding documentation to scrap from a lot or serial number.
  • Adding documentation to revert a scrap operation.
  • Updating Moves History report documentation to include new "Scrapped" filter.

This 19.1 PR has been reviewed by the developer and is ready for writer review.

@erjer-odoo erjer-odoo self-assigned this Dec 17, 2025
@erjer-odoo erjer-odoo added the 5 label Dec 17, 2025
@robodoo
Copy link
Collaborator

robodoo commented Dec 17, 2025

Pull request status dashboard

@erjer-odoo
Copy link
Contributor Author

Hi @theRealThagomizer -- I know that I have a couple of checks failing. I've reached out to the developer of the feature I'm documenting to see if there's anything he can do to help me resolve those. In the meantime, can you look at the content and let me know whether you approve? Thank you!

Copy link
Contributor

@theRealThagomizer theRealThagomizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya, @erjer-odoo! I had a bit more feedback this go around because I think there's room for general improvement in tightening up the sentences and paragraphs in this page. It looks like the original author had a penchant for separating clauses with commas and turning things into 1-2 line paragraphs and parentheticals that all seem sort of odd in technical writing. To me, at least.

If this is a rush job, I think the whole thing can move on, but if not, I'd like to see this again. The new material you wrote in this page seemed much stronger than the extant stuff, so I'd like to see your keen editorial eye aimed at bringing the whole thing in line with your voice. I feel like it'll be a stronger piece for it. Plus, that'll probably be a full rework of the page at that point, no?

Thank you!

@mohammadhossam mohammadhossam force-pushed the master-remove-scrap-model-abdu branch from b239721 to d23af68 Compare December 18, 2025 09:07
@erjer-odoo erjer-odoo force-pushed the master-remove-scrap-model-abdu branch from b7e213b to 37e5e73 Compare December 18, 2025 17:29
@erjer-odoo
Copy link
Contributor Author

Hi @theRealThagomizer -- I've made some updates to hopefully make this a bit stronger. I've condensed content into fewer paragraphs, and I shifted around where a couple of screenshots appear so that they display after we describe all of the fields in the form. What do you think?

Let me know if you approve! Thank you!

@theRealThagomizer
Copy link
Contributor

Looks good, @erjer-odoo! This flows much more naturally than than the existing page, especially with the new section you've added. Ready to move on!

@erjer-odoo erjer-odoo requested a review from Felicious December 19, 2025 19:20
@erjer-odoo
Copy link
Contributor Author

Hi @Felicious -- this 19.1 PR was reviewed by the developer and by @theRealThagomizer (who approved it). It should be ready for publication on the 5th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants