-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] Inventory: Update stock moves documentation #15776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @theRealThagomizer -- I know that I have a couple of checks failing. I've reached out to the developer of the feature I'm documenting to see if there's anything he can do to help me resolve those. In the meantime, can you look at the content and let me know whether you approve? Thank you! |
theRealThagomizer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya, @erjer-odoo! I had a bit more feedback this go around because I think there's room for general improvement in tightening up the sentences and paragraphs in this page. It looks like the original author had a penchant for separating clauses with commas and turning things into 1-2 line paragraphs and parentheticals that all seem sort of odd in technical writing. To me, at least.
If this is a rush job, I think the whole thing can move on, but if not, I'd like to see this again. The new material you wrote in this page seemed much stronger than the extant stuff, so I'd like to see your keen editorial eye aimed at bringing the whole thing in line with your voice. I feel like it'll be a stronger piece for it. Plus, that'll probably be a full rework of the page at that point, no?
Thank you!
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Show resolved
Hide resolved
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
b239721 to
d23af68
Compare
...ions/inventory_and_mrp/inventory/warehouses_storage/inventory_management/scrap_inventory.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: theRealThagomizer <[email protected]>
b7e213b to
37e5e73
Compare
|
Hi @theRealThagomizer -- I've made some updates to hopefully make this a bit stronger. I've condensed content into fewer paragraphs, and I shifted around where a couple of screenshots appear so that they display after we describe all of the fields in the form. What do you think? Let me know if you approve! Thank you! |
|
Looks good, @erjer-odoo! This flows much more naturally than than the existing page, especially with the new section you've added. Ready to move on! |
|
Hi @Felicious -- this 19.1 PR was reviewed by the developer and by @theRealThagomizer (who approved it). It should be ready for publication on the 5th. |

Updating documentation for scrapping in Odoo for 19.1 release.
This 19.1 PR has been reviewed by the developer and is ready for writer review.