Skip to content

Conversation

@meval1006
Copy link
Contributor

@meval1006 meval1006 commented Dec 17, 2025

Added a new section, Customizing payment amounts, on the Online payments page.

This section covers new fields that are a part of a v 19.2 update:

  • Minimum Amount
  • Pricelists

Also, covered the remaining fields in the Availability section, as they were not previously documented. Included a screenshot of the section as an example.

Task: https://www.odoo.com/odoo/action-4043/5426674

@meval1006 meval1006 self-assigned this Dec 17, 2025
@meval1006 meval1006 added the 3 label Dec 17, 2025
@robodoo
Copy link
Collaborator

robodoo commented Dec 17, 2025

Pull request status dashboard

@meval1006 meval1006 force-pushed the master-accounting-payment-provider-restrictions-meval branch from 199a9db to 4aaa1d3 Compare December 17, 2025 22:50
@meval1006 meval1006 marked this pull request as ready for review December 17, 2025 22:50
@meval1006 meval1006 requested a review from csan-odoo December 17, 2025 22:50
@C3POdoo C3POdoo requested a review from a team December 17, 2025 22:52
@meval1006
Copy link
Contributor Author

Hi @csan-odoo, I am a technical writer from the SF office, and I have documented the v19.1 update to the pricelist and amount restrictions for Payment Providers. Please review the PR and let me know if you have any feedback. I appreciate your help.

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @meval1006!

One small general reminder before diving into specifics: whenever possible, it’s worth double-checking the existing docs to avoid repeating information, either across the documentation as a whole or within the same page like it's the case here, unless there’s a strong reason to do so.

A couple of general points on this PR:

  • For payment provider documentation, we usually use [TAG] payment_providers: xyz. Could you please update the PR title and commit message accordingly?
  • It looks like the related RD PR won’t make it into the 19.1 freeze, which means the feature will be available in 19.2 rather than 19.1. As a result, we’ll hold off on merging this documentation PR for now as well.

Thanks again!

@meval1006 meval1006 changed the title [IMP] accounting: payment provider amount restrictions [IMP] payment_providers: payment provider amount restrictions Dec 18, 2025
@meval1006 meval1006 force-pushed the master-accounting-payment-provider-restrictions-meval branch from 4aaa1d3 to 8557e6f Compare December 18, 2025 21:58
@meval1006 meval1006 requested a review from auva-odoo December 18, 2025 21:58
@meval1006
Copy link
Contributor Author

Hi @auva-odoo, I have followed your suggestions, and I also removed the use of 'you' or 'your' and some other minor style guide edits. This is ready for another review pass.

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, @meval1006! 🙏

In addition to my individual comments, I’d suggest keeping this PR focused on the new fields and moving all changes that aren’t directly related to the new features (taking into account my comments and suggestions) into a separate PR targeting 17.0.

Those changes are mostly valid and useful, but for edits not tied to new Odoo features or the UI, I prefer updating the oldest version possible. Targeting the latest version instead can create extra work later and updating the oldest version when possible also helps keep the documentation cleaner overall.

Additionally, could you please remove all changes where the text includes phrases like “the user blabla” and either revert to the original wording or use the imperative form when appropriate? I’ve flagged a couple of examples, but there are more, and I felt a general comment is more time-efficient.

Thanks so much!

@meval1006 meval1006 force-pushed the master-accounting-payment-provider-restrictions-meval branch from 483492e to 8ce3873 Compare December 19, 2025 19:40
@meval1006
Copy link
Contributor Author

Hi @auva-odoo, I have reverted the style guide change as you suggested. The only ones I kept are the naming convention for the PNG files. Please review the Availability section to see if you agree with the final version. I rewrote some of it to include the 'you's and also keep it current with the update.

Thank you again for all the support you've given.

@meval1006 meval1006 added 2 and removed 3 labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants