-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] payment_providers: payment provider amount restrictions #15775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[IMP] payment_providers: payment provider amount restrictions #15775
Conversation
199a9db to
4aaa1d3
Compare
|
Hi @csan-odoo, I am a technical writer from the SF office, and I have documented the v19.1 update to the pricelist and amount restrictions for Payment Providers. Please review the PR and let me know if you have any feedback. I appreciate your help. |
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work @meval1006!
One small general reminder before diving into specifics: whenever possible, it’s worth double-checking the existing docs to avoid repeating information, either across the documentation as a whole or within the same page like it's the case here, unless there’s a strong reason to do so.
A couple of general points on this PR:
- For payment provider documentation, we usually use [TAG] payment_providers: xyz. Could you please update the PR title and commit message accordingly?
- It looks like the related RD PR won’t make it into the 19.1 freeze, which means the feature will be available in 19.2 rather than 19.1. As a result, we’ll hold off on merging this documentation PR for now as well.
Thanks again!
4aaa1d3 to
8557e6f
Compare
|
Hi @auva-odoo, I have followed your suggestions, and I also removed the use of 'you' or 'your' and some other minor style guide edits. This is ready for another review pass. |
auva-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, @meval1006! 🙏
In addition to my individual comments, I’d suggest keeping this PR focused on the new fields and moving all changes that aren’t directly related to the new features (taking into account my comments and suggestions) into a separate PR targeting 17.0.
Those changes are mostly valid and useful, but for edits not tied to new Odoo features or the UI, I prefer updating the oldest version possible. Targeting the latest version instead can create extra work later and updating the oldest version when possible also helps keep the documentation cleaner overall.
Additionally, could you please remove all changes where the text includes phrases like “the user blabla” and either revert to the original wording or use the imperative form when appropriate? I’ve flagged a couple of examples, but there are more, and I felt a general comment is more time-efficient.
Thanks so much!
483492e to
8ce3873
Compare
|
Hi @auva-odoo, I have reverted the style guide change as you suggested. The only ones I kept are the naming convention for the PNG files. Please review the Availability section to see if you agree with the final version. I rewrote some of it to include the 'you's and also keep it current with the update. Thank you again for all the support you've given. |

Added a new section, Customizing payment amounts, on the Online payments page.
This section covers new fields that are a part of a v 19.2 update:
Also, covered the remaining fields in the Availability section, as they were not previously documented. Included a screenshot of the section as an example.
Task: https://www.odoo.com/odoo/action-4043/5426674