-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[IMP] Inventory: Bringing least packages current #15753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: saas-18.3
Are you sure you want to change the base?
Conversation
|
Hi @larm-odoo ! I'm finishing up work on the removal strategies docs. This update brings it current, as well as consistent with the other removal strategies docs that I worked on last week. When you get a moment, can you review and let me know what you think? Thank you! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erjer-odoo - great explanation for this. Most of my suggestions are just that, suggestions, so take what you want and toss the rest. My only concern was the last part, in the image with the flour, I can't see how the user would know that the 100kg bag was used. So I would add something else to show how that is verified. Tag me again for a quick look when you're done!
|
|
||
| To understand how the removal strategy works, consider the following example, featuring a warehouse | ||
| that stores packages of flour in bulk packages of `100 kg`. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 11 - "and" instead of "and/or"
We default to a singular one - but I can't comment on the line itself for some reaon
| - :doc:`About removal strategies <../removal_strategies>` | ||
| - `Odoo Tutorials: Least Packages <https://www.odoo.com/slides/slide/5477/share>`_ | ||
|
|
||
| To understand how the removal strategy works, consider the following example, featuring a warehouse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the whole example belongs in an admonition block, because currently it's "imagine if.." then "example: ..." but they are both the same example, so combining them might be visually easier to follow.
| The *packages* feature is used to group products together and is required for the least packages | ||
| removal strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The *packages* feature is used to group products together and is required for the least packages | |
| removal strategy. | |
| The packages feature is used to group products together and is required for the *least packages* | |
| removal strategy. |
I feel the emphasis can be put on the item being discussed, and since the second 'packages' wasn't italiciced in the sentence above, you only need ot use it once. Totally optional!
| Navigate to :menuselection:`Inventory app --> Configuration --> Settings` and select the check box | ||
| for the :guilabel:`Packages` feature. | ||
|
|
||
| .. image:: least_packages/enable-packages-setting.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is necessary since it's a pretty straightforward item - we're just checking a box, there aren't several different options ot ocnfogure with drop-downs, etc.
| Navigate to :menuselection:`Inventory app --> Configuration --> Settings` and select the check box | ||
| for the :guilabel:`Packages` feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Navigate to :menuselection:`Inventory app --> Configuration --> Settings` and select the check box | |
| for the :guilabel:`Packages` feature. | |
| Navigate to :menuselection:`Inventory app --> Configuration --> Settings` and in the :guilabel:`Operations` section, activate the check box | |
| for the :guilabel:`Packages` feature. |
I'll be 110% honest- I cannot remember if it was select or enable, etc. This is just a personal preference- both the extra navigation and 'select'. I realie it's the first thing, but INventory has a LOT of secitons so it might be helpful.
| .. tip:: | ||
| To check the product's on-hand stock, navigate to the product form, and click the :guilabel:`On | ||
| Hand` smart button. | ||
| You can verify the product's on-hand stock in the :guilabel:`Locations` report. Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME tip!
| Consider the following example, featuring the product, `Flour (kg)`. The product's unit of measure, | ||
| located on the product form, is set to `kg`. The product is stored in packages of `100 kg`, with one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Youo could link "unit of measure" to the section in whatever doc there is that explains all of this. Just an idea!
| .. image:: least_packages/on-hand-quantities.png | ||
| :alt: Show on-hand stock in each package. | ||
|
|
||
| Create a :ref:`delivery order <inventory/delivery/one-step>` for eighty kilograms of flour by going |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Create a :ref:`delivery order <inventory/delivery/one-step>` for eighty kilograms of flour by going | |
| A :ref:`delivery order <inventory/delivery/one-step>` is created for eighty kilograms of flour, and confirmed. ``` | |
| Ony because when youa re writing "create.." it implies the user is following along - but this is an example and they won't have the items set up.configured/etc. So I feel it is nice to phrase it as "this happened, then this, etc" You know what I mean? The example is explaining what is happening, but shouldn't be telling the user to do the steps since they wouldn't really be able to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After re-reading this, I would rehrase this to "A sales order is created for..... When it is 'confirmed', a deliveyr order is created.
| For more details about *where* the units were picked, click the :guilabel:`Details` link, located on | ||
| the far-right. Doing so opens the :guilabel:`Detailed Operations` pop-up window, displaying how the | ||
| reserved items were picked, according to the removal strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| For more details about *where* the units were picked, click the :guilabel:`Details` link, located on | |
| the far-right. Doing so opens the :guilabel:`Detailed Operations` pop-up window, displaying how the | |
| reserved items were picked, according to the removal strategy. | |
| For more details about *where* the units were picked, click :guilabel:`Details` on the product line.. Doing so opens the :guilabel:`Detailed Operations` pop-up window, displaying how the | |
| reserved items were picked, according to the removal strategy. |
I just wasn't sure where I was lookingn, and just tought it woudl be helpful to say it's ont he line.
| In the :guilabel:`Detailed Operations` pop-up window, the :guilabel:`Pick From` field displays where | ||
| the quantities to fulfill the :guilabel:`Demand` are picked. Because the order demanded eighty | ||
| kilograms, which exceeds the quantity in the opened package of `54 kg`, an unopened package of `100 | ||
| kg` is selected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In the :guilabel:`Detailed Operations` pop-up window, the :guilabel:`Pick From` field displays where | |
| the quantities to fulfill the :guilabel:`Demand` are picked. Because the order demanded eighty | |
| kilograms, which exceeds the quantity in the opened package of `54 kg`, an unopened package of `100 | |
| kg` is selected. | |
| In the :guilabel:`Detailed Operations` pop-up window, the :guilabel:`Pick From` field displays where | |
| the quantities to fulfill the :guilabel:`Demand` are picked. Because the order demands eighty | |
| kilograms, which exceeds the quantity in the opened package of `54 kg`, an unopened package of `100 | |
| kg` is selected. |
2 things- I felt 'demands' sounded right, but you decide! Also, I was confused, because it mentions that a 100kg bag is used, but it's not shown on the form. Is there any way to tell what was taken? Or are you just explaining information that is not available from the form? I was tyring to follow along and see where it's verified that the 100kg bag was used form the pop-up, but it just does'nt give the info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, is there another way to veirfy/see what bag was used for this order? Maybe it's on another screen or report? I'm just thinking out loud, because if I was a worker, from this image, I wouldn't know that a 100kg bag was used- I could think that a 50 and a 50 were used/combined.

While working on the removal strategies overview script, I realized that the documentation for "Least packages removal" was out of date. In this PR, I did the following:
All of this work makes the last of the removal strategies docs consistent with the other removal strategies docs.
This saas-18.3 PR can be FWP up to master.