Skip to content

requesthandler: Fix AcquireSource without canvas#1334

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
exeldro:fix_source_by_name
Mar 3, 2026
Merged

requesthandler: Fix AcquireSource without canvas#1334
RytoEX merged 1 commit intoobsproject:masterfrom
exeldro:fix_source_by_name

Conversation

@exeldro
Copy link
Contributor

@exeldro exeldro commented Mar 2, 2026

Description

Fix AcquireSource without canvas

Motivation and Context

Don't like broken stuff
Fixing #1333

How Has This Been Tested?

Tested OS(s): Windows 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested review from Warchamp7 and tt2468 March 2, 2026 18:06
@exeldro exeldro force-pushed the fix_source_by_name branch from 60be74e to ea4358e Compare March 3, 2026 07:07
Copy link
Member

@tt2468 tt2468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it does fix the issue. Unfortunately, the error messages will be a bit awkward for inputs, since they suggest that an input was not found in some canvas, even though inputs cannot exist in a canvas at all. I think the oversight is minor enough to not be worth delaying this fix, though.

@RytoEX RytoEX merged commit 680003b into obsproject:master Mar 3, 2026
1 check passed
@exeldro exeldro deleted the fix_source_by_name branch March 3, 2026 21:44
@RytoEX RytoEX linked an issue Mar 3, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text GDI stop working with Streamer BOT

3 participants