Skip to content

Revert custom scheme handler protocol#515

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
Warchamp7:revert-scheme-change
Feb 13, 2026
Merged

Revert custom scheme handler protocol#515
RytoEX merged 1 commit intoobsproject:masterfrom
Warchamp7:revert-scheme-change

Conversation

@Warchamp7
Copy link
Member

Description

Reverts the change to obsbrowser://file/ in #511

Fixes #514

Motivation and Context

The change to a custom scheme was meant to harden protections of our custom handler for local files. Swapping to a custom protocol other than http lost us a few freebies that would require a bunch more special handling. Reverting back for now is the easiest solution while still addressing the original motivation for changing it.

How Has This Been Tested?

Tested with a local HTML file that loaded a local .webm video asset.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 added the Bug Fix Non-breaking change which fixes an issue label Feb 12, 2026
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight revert of the prior state for these lines?

@RytoEX
Copy link
Member

RytoEX commented Feb 12, 2026

This is a straight revert of the prior state for these lines?

Based on the changes in #511, that seems to be the case except for the comment lines.

@Warchamp7
Copy link
Member Author

Correct

@RytoEX RytoEX requested a review from PatTheMav February 12, 2026 22:53
@RytoEX RytoEX merged commit cda4f1f into obsproject:master Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio files could not be loaded in the browser source due to DOMException: Failed to load because no supported source was found.

3 participants