Add getItemTransform function#499
Closed
deemonrider wants to merge 1 commit intoobsproject:masterfrom
Closed
Conversation
Member
|
This approach using |
6 tasks
Author
I hadn’t considered that, thanks for pointing it out. I’ve reworked the implementation and opened a new PR, so I’ll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This new feature adds a getItemTransform function to the browser source to retrieve its own transformation information
(position, scale, rotation, alignment, bounds, crop, and dimensions) with the default basic permission READ_OBS.
Motivation and Context
I can provide further reasons if needed, but I think the case is clear.
How Has This Been Tested?
Environment: Windows 11 x64, OBS Studio 31.1.2 (build 104)
For example, take a look at the screenshot and the distorted aspect ratio. With this function, I could either display an error message informing the user not to stretch the browser source, or alternatively, automatically adjust the aspect ratio internally to prevent it from breaking.
Types of changes
New feature (non-breaking change which adds functionality)
Documentation (a change to documentation pages)
Checklist: