Add function to signal the browser source from JavaScript#439
Open
exeldro wants to merge 1 commit intoobsproject:masterfrom
Open
Add function to signal the browser source from JavaScript#439exeldro wants to merge 1 commit intoobsproject:masterfrom
exeldro wants to merge 1 commit intoobsproject:masterfrom
Conversation
Warchamp7
reviewed
Apr 13, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds
void source_browser_signal(ptr source, string signal)to the global signal handleradds
void browser_signal(ptr source, string signal)to the signal handler of the browser sourcein javascript you can signal a signal handler like this:
window.obsstudio.signal("signal")Motivation and Context
Allow JavaScript to send signals to plugins, without the need for an obs websocket connection
More generic solution replacing #423
The use case is my Markdown Source plugin. I want to me able to size the browser source to its contents provided by the markdown. I could hack a way by forcing obs-websocket enabled and getting the obs-websocket port and password from the settings and provide that to the the browser source, but I prefer a way that I don't have to force users to enable obs-websocket.
How Has This Been Tested?
On windows 11 with changes to the markdown source to allow it to resize it self
Types of changes
Checklist: