Simplify simplehttp, updating to newer python standards#197
Merged
RytoEX merged 1 commit intoobsproject:masterfrom Jan 14, 2026
Merged
Simplify simplehttp, updating to newer python standards#197RytoEX merged 1 commit intoobsproject:masterfrom
RytoEX merged 1 commit intoobsproject:masterfrom
Conversation
2b0c6c3 to
d0b76ca
Compare
RytoEX
requested changes
Jan 8, 2026
Member
RytoEX
left a comment
There was a problem hiding this comment.
Use simplehttp: as the commit prefix here.
Is there no need to call loop.close() in this implementation?
6 tasks
d0b76ca to
999b62c
Compare
There's actually no need to run the _run_app() function using a loop we create. Just add an on_startup hook to override the thread pool. Python asyncio automatically shuts down our custom thread pool executor on loop shutdown, so there's no need for any shutdown logic either. asyncio.to_thread will automatically use the running loop's thread pool executor, which is the one we've created ourselves.
999b62c to
b50db88
Compare
Member
Author
|
Correct. |
RytoEX
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's actually no need to run the _run_app() function using a loop we create. Just add an on_startup hook to override the thread pool. Python asyncio automatically shuts down our custom thread pool executor on loop shutdown, so there's no need for any shutdown logic either.
asyncio.to_thread will automatically use the running loop's thread pool executor, which is the one we've created ourselves.
Motivation and Context
I guess my shitty python code from a few years ago is getting deprecation warnings now.
How Has This Been Tested?
Analyzed some logs of mine
Types of changes
Checklist: