Fix UNKNOWN package name when installing with --no-build-isolation#5
Open
AshadowZ wants to merge 1 commit intonv-tlabs:mainfrom
Open
Fix UNKNOWN package name when installing with --no-build-isolation#5AshadowZ wants to merge 1 commit intonv-tlabs:mainfrom
AshadowZ wants to merge 1 commit intonv-tlabs:mainfrom
Conversation
Collaborator
|
Thank you for making this PR! I will review it ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
When installing this package using
pip install . --no-build-isolation(which is common practice for CUDA extensions to reuse the host's PyTorch environment), pip skips creating a temporary build environment and instead relies on the host system'ssetuptools.If the host's
setuptoolsversion is older than 61.0.0, it does not support PEP 621 and ignores the[project]metadata table inpyproject.toml. As a result,setup.pyfails to retrieve the package name and version, causing the package to be built and installed as:UNKNOWN-0.0.0
Proposed Changes
This PR modifies
setup.pyto explicitly pass thenameandversionarguments to thesetup()function.