Skip to content

[Misc]feat: adapt to vLLM main (c7aa186d...50acdc5b) - #242

Draft
Meihan-chen wants to merge 36 commits into
nv-action:mainfrom
Meihan-chen:main2main_auto_2026-05-14_09-51
Draft

[Misc]feat: adapt to vLLM main (c7aa186d...50acdc5b)#242
Meihan-chen wants to merge 36 commits into
nv-action:mainfrom
Meihan-chen:main2main_auto_2026-05-14_09-51

Conversation

@Meihan-chen

@Meihan-chen Meihan-chen commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Main2Main Summary

Status: completed
Upstream range: c7aa186d67b6f051680831418e957c67f34ba7a2..50acdc5b5cc00f10408d8f98b21fc97efc615173
Reached upstream commit: 50acdc5b5cc00f10408d8f98b21fc97efc615173
Steps: 9/9
CI suite: e2e-main2main

Result

The main2main pipeline successfully absorbed all 30 upstream vLLM commits (c7aa186d67b6f051680831418e957c67f34ba7a2 to 50acdc5b5cc00f10408d8f98b21fc97efc615173) across 9 steps. All CI tests passed for each step. The target commit was reached with verified code.

Completed Steps

Step Upstream range vllm-ascend commit CI result Summary
step-1 c7aa186..16e3364 5b1fa76 passed Mistral tokenizer leniency update (commit reference only)
step-2 16e3364..5d0fd87 7c8a377 passed Spec decode multimodal warning, PP async scheduling fix
step-3 5d0fd87..242afc6 b0bee0c passed Gemma4 encoder budget max_soft_tokens (commit reference only)
step-4 242afc6..df8e63f 91d9989 passed nixl refactor (commit reference only)
step-5 df8e63f..f39bcf1 136c4a5 passed KV offload lookup fix, tool_choice None content (commit reference only)
step-6 f39bcf1..27e0057 2367b61 passed Gemma4 MTP spec decode support (commit reference only)
step-7 27e0057..38e1667 07d6aa1 passed PP token handling fix, block table alignment (commit reference only)
step-8 38e1667..ca3e62d c532096 passed TPU requirements update (commit reference only)
step-9 ca3e62d..50acdc5 1da68e3 passed Qwen3 streaming content routing fix (commit reference only)

Changes Made

  • Updated vLLM commit reference from c7aa186d67b6f051680831418e957c67f34ba7a2 to 50acdc5b5cc00f10408d8f98b21fc97efc615173.
  • Adapted speculative decoding: renamed _raise_if_multimodal to _warn_if_multimodal in vllm_ascend/spec_decode/dflash_proposer.py.
  • Updated PP async scheduling condition: changed from get_pp_group().world_size > 1 to not get_pp_group().is_last_rank in vllm_ascend/worker/model_runner_v1.py.

CI Verification

  • Passed: All 9 steps passed e2e-main2main CI suite
  • Treated as env flakes: none
  • Last successful step: step-9

Adaptations Summary

Only 2 code adaptations were required across 30 upstream commits:

  1. Speculative decoding: Method rename _raise_if_multimodal_warn_if_multimodal (step-2)
  2. PP async scheduling: Condition change for last rank check (step-2)

All other changes (nixl refactor, Gemma4 MTP, KV offload, block table alignment, parser fixes, etc.) were handled automatically by vllm-ascend inheriting from upstream or not using the affected features (TRTLLM, ROCm, TPU, nixl connector, Gemma4).

Meihan-chen and others added 30 commits May 12, 2026 14:16
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <jcccx.cmh@gmail.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Signed-off-by: Meihan-chen <239345480+Meihan-chen@users.noreply.github.com>
Upstream range: c7aa186d67b6f051680831418e957c67f34ba7a2..16e336491e96041946e2cd379a80034fcac439bd

Changes:
- Updated mistral_common version requirement from 1.11.0 to 1.11.2
- Refactored Mistral tokenizer: removed adapt_inplace_to_mistral_tool,
  renamed _prepare_apply_chat_template_tools_and_messages to
  _validate_apply_chat_template_args
- Mistral tool parser updated to use MistralTool.from_openai()

No vllm-ascend adaptation needed (no usage of changed functions).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: 16e336491e96041946e2cd379a80034fcac439bd..5d0fd87038b123a11dd9c85a05ce2d258e27ce7b

Key upstream changes absorbed:
- [Spec Decode] Allow multimodal models with a warning (#41752)
  - Renamed _raise_if_multimodal to _warn_if_multimodal in base proposer
- [Bugfix] Skip PP sampled-token receive on last rank during async scheduling (#40749)
  - Changed condition from get_pp_group().world_size > 1 to not get_pp_group().is_last_rank

vllm-ascend adaptations:
- vllm_ascend/spec_decode/dflash_proposer.py: renamed _raise_if_multimodal to _warn_if_multimodal
- vllm_ascend/worker/model_runner_v1.py: updated PP async scheduling condition

Other upstream changes (no adaptation needed):
- CPU-specific improvements (dnnl, FP8 support, OMP binding)
- Example/doc reorganization for disaggregated features
- Codegen fix for unqualified names
- XPU platform CUDA graph fix
- ROCm Aiter MoE fix

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Upstream range: 5d0fd87038b123a11dd9c85a05ce2d258e27ce7b..242afc6bf40d6d088b7b97eda1dd7f00ddcdfa21

Changes:
- [MM][Gemma4] Respect max_soft_tokens in encoder budget (#41799)
- Added _get_max_soft_tokens helper function
- Modified get_mm_max_tokens_per_item to respect configured max_soft_tokens

No vllm-ascend adaptation needed (no Gemma4-related code).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: main2main-bot <main2main-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation merge-conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants